Skip to content

Commit

Permalink
Fixes #476
Browse files Browse the repository at this point in the history
  • Loading branch information
oharsta committed Jan 16, 2025
1 parent 59fbc97 commit 0bc9afa
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 2 deletions.
4 changes: 2 additions & 2 deletions manage-server/src/main/java/manage/control/PdPController.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ public String decideManage(@RequestBody String payload) {
return pdpRestTemplate.exchange(this.decideUrl, HttpMethod.POST, requestEntity, String.class).getBody();
}

@PreAuthorize("hasRole('ADMIN')")
@GetMapping(value = "/client/pdp/missing-enforcements")
@PreAuthorize("hasAnyRole('ADMIN', 'READ')")
@GetMapping(value = {"/client/pdp/missing-enforcements", "/internal/pdp/missing-enforcements"})
public List<MetaData> policiesWithMissingPolicyEnforcementDecisionRequired() {
return metaDataRepository.policiesWithMissingPolicyEnforcementDecisionRequired();
}
Expand Down
30 changes: 30 additions & 0 deletions manage-server/src/test/java/manage/control/PdPControllerTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package manage.control;

import io.restassured.common.mapper.TypeRef;
import manage.AbstractIntegrationTest;
import org.junit.Test;

import java.util.List;
import java.util.Map;

import static io.restassured.RestAssured.given;
import static org.apache.http.HttpStatus.SC_OK;
import static org.hamcrest.Matchers.equalTo;
import static org.junit.Assert.*;

public class PdPControllerTest extends AbstractIntegrationTest {

@Test
public void policiesWithMissingPolicyEnforcementDecisionRequired() {
List<Map<String, Object>> metaDataList = given()
.when()
.auth()
.preemptive()
.basic("sp-portal", "secret")
.get("manage/api/internal/pdp/missing-enforcements")
.as(new TypeRef<>() {
});
assertEquals(2, metaDataList.size());
metaDataList.forEach(metaData -> assertEquals("policy",metaData.get("type")));
}
}

0 comments on commit 0bc9afa

Please sign in to comment.