-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved memory handling in oc_dialog::SortUUIDList #1126
base: main
Are you sure you want to change the base?
Improved memory handling in oc_dialog::SortUUIDList #1126
Conversation
Improved memory handling and early release of allocated resources short improve situatin for Issue OpenCollarTeam#1119.
This patch also allow the full number of 32 sensor results to be used in the sensor handling, not in the current patch but its a simple change. Also tested in places where force sit returns 32 results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for functionality, everything appears to work as expected. The Force Sit function now returns 32 items without error, and the detach app will also return 32 worn items without crashing.
I believe that @Medea-Destiny would like to review this scrpt for workflow. I will approve this and tag it with Don't Merge Yet awaiting Medea's review
Looks great at a first go through, but I'll take a closer look in case I can think of any possible issues / interactions. For the sake of safety (and possibly menu legibility) it might be an idea to continue to clamp the force sit function - maybe to 20 instead of 16? How do people feel about that? |
The issue with 32 force sits is actually the same as with 32 worn items in Detach, so why ?? |
Improved memory handling and early release of allocated resources should improve situation for Issue #1119. Simple drop in replacement for oc_dialog.
This version has been tested for two months and no regressions seen.
As long as only a single owner is accessing the Detach app menus at a time problem should be fixed.