Nikki lacrima minorclean rlvsuite #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like good and sensible fixes to me. However as we've got release candidates for 8.3 out I'd suggest it might be best to push this to 8.4 for a release a few months down the line as these are efficiency improvements rather than bugfixes and we really want to get 8.3 actually release :D Thoughts? |
|
These changes are not critical, just minor annoyances. So they can wait, but if we prepare another RC before release of 8.3 they might go in. |
SilkieSabra
merged commit c62a3ce
into
OpenCollarTeam:8.3_Features-branch
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two are parts:
Remove superflous llOwnerSay and change the "0" flag to "1" in the NOTIFY when modifying restrictions.
The current code sends two sets of notifications to wearer if wearer changes restrictions.
g_iMenuStride was unitintialized so lets remove kMenuID stuff and replace with sName+"~"+llGetScriptName() as in the #963 patch. This change has been in oc_api and oc_core for quite a while now so should be considered well tested. Code is simpler and uses slightly less memory.