Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Error when accessing the Observables tab in a workbench (#9543) #9551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SarahBocognano
Copy link
Member

@SarahBocognano SarahBocognano commented Jan 9, 2025

Proposed changes

  • Remove 'dst_port' attribute in sorting by default_value

Since it's a wrong usage of filter that is used by the workbenck when checking if an observable already exists it's hard to write a test coverage.

Root cause is that generated filter is this one with dst_port that is a number in satabase shemas :

{
  "types": [
    "Domain-Name"
  ],
  "search": null,
  "filters": {
    "mode": "and",
    "filters": [
      {
        "key": [
          "name",
          "value",
          "aliases",
          "x_opencti_aliases",
          "value",
          "content",
          "attribute_key",
          "path",
          "hashes.MD5",
          "hashes.SHA-1",
          "hashes.SHA-256",
          "hashes.SHA-512",
          "dst_port"
        ],
        "values": [
          "wwww.toto.fr"
        ]
      }
    ],
    "filterGroups": []
  },
  "count": 1
}

Related issues

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Jan 9, 2025
@SarahBocognano SarahBocognano self-assigned this Jan 9, 2025
@SarahBocognano SarahBocognano linked an issue Jan 9, 2025 that may be closed by this pull request
@marieflorescontact marieflorescontact self-requested a review January 9, 2025 15:03
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.15%. Comparing base (a222b52) to head (4f52b81).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9551      +/-   ##
==========================================
+ Coverage   65.13%   65.15%   +0.01%     
==========================================
  Files         630      630              
  Lines       60110    60110              
  Branches     6694     6698       +4     
==========================================
+ Hits        39155    39162       +7     
+ Misses      20955    20948       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg
Copy link
Member

labo-flg commented Jan 9, 2025

We will open another PR to discuss about adding non-regression tests.
This is not trivial (nor wise?) to do this in e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when accessing the Observables tab in a workbench
3 participants