Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] add missing Task/Report/Grouping/Malware Analysis in knowledge > related entities (#9497) #9498

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

delemaf
Copy link
Member

@delemaf delemaf commented Jan 3, 2025

Proposed changes

  • ⚠️ In relation table
  • Use representative.main for missing entities Task/Report/Grouping/Malware Analysis in query
  • Global refactor/clean of entities/observables repetition

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf self-assigned this Jan 3, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.19%. Comparing base (a5affd2) to head (cb02be5).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9498   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files         628      628           
  Lines       59961    59961           
  Branches     6687     6687           
=======================================
  Hits        39091    39091           
  Misses      20870    20870           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delemaf delemaf changed the title [frontend] add missing Task/Report/Malware/Malware Analysis in knowledge > related entities (#9497) [frontend] add missing Task/Report/Malware/Malware Analysis/Network Traffic in knowledge > related entities (#9497) Jan 6, 2025
@delemaf delemaf changed the title [frontend] add missing Task/Report/Malware/Malware Analysis/Network Traffic in knowledge > related entities (#9497) [frontend] add missing Task/Report/Grouping/Malware Analysis in knowledge > related entities (#9497) Jan 6, 2025
@delemaf delemaf merged commit 6fa6985 into master Jan 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task/Report/Grouping/Malware Analysis name are Unknown in knowledge related entities
2 participants