-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] fix Sightings tab under Observables and Indicators (#8814) #9486
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9486 +/- ##
==========================================
+ Coverage 65.34% 65.48% +0.13%
==========================================
Files 624 628 +4
Lines 59697 60313 +616
Branches 6685 6943 +258
==========================================
+ Hits 39010 39494 +484
- Misses 20687 20819 +132 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I create a sighting
from organization
, then click on the created sighting
i'm redirected to the indicator knowledge tab and sighting is in sighting tab 👌. is that correct?
Don't we want to be redirected to /dashboard/events/sightings/{sighting_id}
. as commented in the issue:
#8146
if it's ok to be redirected to the entity's knowlede page then it works fine.
Proposed changes
Related issues
Checklist
Further comments