Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix Sightings tab under Observables and Indicators (#8814) #9486

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Jan 3, 2025

Proposed changes

  • isTo become false in the sightings indicator and observables

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe self-assigned this Jan 3, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 3, 2025
@CelineSebe CelineSebe linked an issue Jan 3, 2025 that may be closed by this pull request
@CelineSebe CelineSebe linked an issue Jan 3, 2025 that may be closed by this pull request
@CelineSebe CelineSebe marked this pull request as ready for review January 3, 2025 10:12
@CelineSebe CelineSebe changed the title [frontend] fix Sightings tab under Observables and Indicators [frontend] fix Sightings tab under Observables and Indicators (#8814)(#8146) Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.48%. Comparing base (d47dbae) to head (d444213).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9486      +/-   ##
==========================================
+ Coverage   65.34%   65.48%   +0.13%     
==========================================
  Files         624      628       +4     
  Lines       59697    60313     +616     
  Branches     6685     6943     +258     
==========================================
+ Hits        39010    39494     +484     
- Misses      20687    20819     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact self-requested a review January 3, 2025 15:24
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I create a sighting from organization, then click on the created sighting i'm redirected to the indicator knowledge tab and sighting is in sighting tab 👌. is that correct?
Don't we want to be redirected to /dashboard/events/sightings/{sighting_id}. as commented in the issue:
#8146
if it's ok to be redirected to the entity's knowlede page then it works fine.

@CelineSebe CelineSebe changed the title [frontend] fix Sightings tab under Observables and Indicators (#8814)(#8146) [frontend] fix Sightings tab under Observables and Indicators (#8814) Jan 7, 2025
@marieflorescontact marieflorescontact self-requested a review January 7, 2025 09:29
@CelineSebe CelineSebe merged commit 5526f43 into master Jan 7, 2025
9 checks passed
@CelineSebe CelineSebe deleted the issue/8814 branch January 7, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sightings tab under Observables and Indicators shows no data
2 participants