Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Align knowledge bar counters (#8115) #9304

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

delemaf
Copy link
Member

@delemaf delemaf commented Dec 11, 2024

Proposed changes

  • Fix distribution counters, also add counter for related entities
  • Refactor query with fragment for knowledge bar
  • NB: counters update is still not sync when entity is added (it's another bug 🐛 )

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf added the filigran team use to identify PR from the Filigran team label Dec 11, 2024
@delemaf delemaf self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (be3b778) to head (c8b5808).
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9304      +/-   ##
==========================================
+ Coverage   65.34%   65.90%   +0.56%     
==========================================
  Files         624      630       +6     
  Lines       59697    60588     +891     
  Branches     6685     7459     +774     
==========================================
+ Hits        39010    39933     +923     
+ Misses      20687    20655      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delemaf delemaf closed this Dec 18, 2024
@delemaf delemaf reopened this Dec 27, 2024
@delemaf delemaf changed the title [frontend] Incorrect display in Threat Actors menu category (#8115) [frontend] Align knowledge bar counters (#8115) Dec 27, 2024
@delemaf delemaf marked this pull request as ready for review January 2, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants