[Backend] External reference fail creation as checked attribute is not the good one (#8545)

[richard-julien]

See #8545

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.43%. Comparing base (9754a5e) to head (05a841d).
Report is 36 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8548      +/-   ##
==========================================
+ Coverage   66.21%   66.43%   +0.21%     
==========================================
  Files         597      597              
  Lines       60417    60546     +129     
  Branches     6205     6446     +241     
==========================================
+ Hits        40008    40223     +215     
+ Misses      20409    20323      -86     

Flag	Coverage Δ
	66.43% <100.00%> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SouadHadjiat]

The code change looks all right, but I'm not sure it fixes the issue.
I'm not sure how to reproduce the issue by the way.
I tried to run opencti locally, add a remote octi stream on testing (filtered on reports with a specific label I created).
I create reports with this label on testing => it's well created on my local opencti
I add external ref on this report on testing => it's well added locally
I remove the external ref on this report => KO it's not removed from my local report, the external ref is still present.
Should it be removed with this fix ? what did I miss to reproduce the issue ?

[richard-julien]

The code change looks all right, but I'm not sure it fixes the issue. I'm not sure how to reproduce the issue by the way. I tried to run opencti locally, add a remote octi stream on testing (filtered on reports with a specific label I created). I create reports with this label on testing => it's well created on my local opencti I add external ref on this report on testing => it's well added locally I remove the external ref on this report => KO it's not removed from my local report, the external ref is still present. Should it be removed with this fix ? what did I miss to reproduce the issue ?

Sometimes the external refs was not created at all. To have the deletion you need to activate the advanced option "full sync" on the client side

[SouadHadjiat]

change is good and should fix issues, but I couldn't make sure that the bug related is fixed.

[SouadHadjiat]

With perfect sync advanced option, the external ref is well synchronized (added and removed). But without this option, the remove of external ref or label is not synchronized.

[richard-julien]

With perfect sync advanced option, the external ref is well synchronized (added and removed). But without this option, the remove of external ref or label is not synchronized.

Thats the expected behavior. Without full sync the refs are only cumulated (markings, externals refs, labels, ...)