Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] retention rules on files with status complete or timeout (#7482) #8267

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

Archidoit
Copy link
Member

Proposed changes

Retention rules on files/workbenches should only delete files/workbenches with status = 'complete' or 'timeout' and with works that are all complete or timeout (don't delete if status = 'progress' or 'wait')

Related issues

fix of #7482

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Sep 5, 2024
@Archidoit Archidoit self-assigned this Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.23%. Comparing base (9a5f2b3) to head (f69b70d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...atform/opencti-graphql/src/domain/retentionRule.js 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8267      +/-   ##
==========================================
- Coverage   66.24%   66.23%   -0.01%     
==========================================
  Files         597      597              
  Lines       60315    60325      +10     
  Branches     6197     6200       +3     
==========================================
+ Hits        39954    39955       +1     
- Misses      20361    20370       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard self-assigned this Sep 6, 2024
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to deep dive for the search tool fix. Do not merge yet please.

@aHenryJard aHenryJard self-requested a review September 9, 2024 07:08
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.

@aHenryJard aHenryJard merged commit 79eb8cb into master Sep 9, 2024
6 checks passed
@aHenryJard aHenryJard deleted the issue/7482-fix branch September 19, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants