Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Remove feature flag for bulk entities (#4352) #8229

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Sep 2, 2024

Proposed changes

  • Remove feature flag BULK_ENTITIES

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Sep 2, 2024
@lndrtrbn lndrtrbn self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (79d21ee) to head (e30a37b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8229   +/-   ##
=======================================
  Coverage   66.20%   66.21%           
=======================================
  Files         597      597           
  Lines       60341    60341           
  Branches     6203     6205    +2     
=======================================
+ Hits        39951    39956    +5     
+ Misses      20390    20385    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn changed the title [frontend] Remove feature flag (#4352) [frontend] Remove feature flag for bulk entities (#4352) Sep 3, 2024
@lndrtrbn lndrtrbn force-pushed the issue/4352-del-ff-entities branch from c467996 to c0c5de5 Compare September 11, 2024 07:29
@lndrtrbn lndrtrbn merged commit 13e8b1f into master Sep 11, 2024
5 checks passed
@lndrtrbn lndrtrbn deleted the issue/4352-del-ff-entities branch September 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants