[graphql] Replace [email protected] w/ @sesamecare-oss/[email protected]

[ckane]

Proposed changes

Replace redlock TS module with @sesamecare-oss/redlock which is a rewrite of the algorithm. The older redlock project hasn't released a new release since a 5.0.0 beta in March of 2023.

Related issues

This was discussed in #6285 - it is not yet determined if this will address the reported problems. I am currently doing some testing, but wanted to open the PR as a preliminary reference for tracking the code changes that need to occur

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case (coverage and e2e)
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.12%. Comparing base (17ea383) to head (9184c53).
Report is 1 commits behind head on release/6.5.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release/6.5.0    #6622   +/-   ##
==============================================
  Coverage          65.12%   65.12%           
==============================================
  Files                626      626           
  Lines              59784    59784           
  Branches            6663     6660    -3     
==============================================
  Hits               38937    38937           
  Misses             20847    20847           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ckane]

This does not solve the problems discussed in #6285 but it has been working without regressions for two days on my instances

[ckane]

This does not solve the problems discussed in #6285 but it has been working without regressions for two days on my instances

The problems discussed in #6285 were fixed in #6640, but still recommend this change due to upstream maintenance state of current redlock package

[ckane]

Rebased against current master branch, and also updated the version of redlock to latest 1.3.1

[ckane]

Also not sure what I need to do to clear the "lockfile would be updated" error in the api-tests in the drone CI run. My expectation is I did the npm/yarn upgrade incorrectly and there's something else which needs to be updated too. If you point me at what I need to do I'll fix it and update my tree as well.

[richard-julien]

Really sorry about this one @ckane , will do some test and merge that in couple of weeks.
For yarn locks you can remove the lock file and regenerate it with yarn install, should resolve the conflicts.

[ckane]

Ok thanks @richard-julien - I just pushed a missing dependency that hopefully fixes it. Also re-committed my commits as signed, which I forgot to do earlier.

[richard-julien]

Hi @ckane , can you remove "redlock": "5.0.0-beta.2" in package.json and redo a yarn install.
I think its the reason the PR fail.
Thanks

[ckane]

Hi @ckane , can you remove "redlock": "5.0.0-beta.2" in package.json and redo a yarn install. I think its the reason the PR fail. Thanks

Thanks @richard-julien, I messed up the rebase. Should be good now.

[richard-julien]

Hi @ckane , Im really sorry, im back after some inactivity period, and just change the target from master to 6.5.0.
Looks like there is a conflict :( Can you rebase again and then I will merge the PR ... finally :)

[ckane]

Hi @ckane , Im really sorry, im back after some inactivity period, and just change the target from master to 6.5.0. Looks like there is a conflict :( Can you rebase again and then I will merge the PR ... finally :)

No worries - should be rebased against release/6.5.0 now

[ckane]

Hm looks like it pulled in a whole bunch of other commits or something. I will try branching a new branch from release/6.5.0 and manually cherry-pick the relevant commits to that

[richard-julien]

Merged for 6.5.0. Thanks @ckane