Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:slot tag #2571

Closed
wants to merge 1 commit into from
Closed

Conversation

chejinge
Copy link
Collaborator

@chejinge chejinge commented Apr 1, 2024

#2555
这个为啥必须是1024以内这个又不是slot,需要和这个 同学对一下

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Apr 1, 2024
@chejinge chejinge changed the title fix:slot tag 【wip】fix:slot tag Apr 1, 2024
@chejinge chejinge changed the title 【wip】fix:slot tag fix:[wip]slot tag Apr 1, 2024
@chejinge chejinge changed the title fix:[wip]slot tag fix:slot tag Apr 1, 2024
@@ -769,7 +769,7 @@ int GetKeyType(const std::string& key, std::string& key_type, const std::shared_

// get slotstagkey by key
std::string GetSlotsTagKey(uint32_t crc) {
return SlotTagPrefix + std::to_string(crc);
return SlotTagPrefix + std::to_string(crc% g_pika_conf->default_slot_num());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在百分号前面加个空格吧

@chejinge chejinge closed this Apr 2, 2024
@chejinge chejinge deleted the fix_slot_tag branch June 24, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.4 4.0.0 ☢️ Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants