fix: fix user ERR NOAUTH Authentication required

[buzhimingyonghu]

solve has requirepass & blacklist

Summary by CodeRabbit

• New Features

  • Introduced a new configuration parameter best-delete-min-ratio for improved compaction strategy.
  • Added the InitUser method to enhance user initialization in connection contexts.

• Bug Fixes

  • Improved logging in the AuthRequired method for better authentication insights.

• Style

  • Enhanced code readability through consistent formatting and comment adjustments across multiple files.

[coderabbitai]

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on the addition of a new configuration parameter best-delete-min-ratio in conf/pika.conf and the introduction of the InitUser method in the PikaClientConn class. Additionally, minor formatting adjustments were made in various files to enhance code readability and maintain consistency. Overall, the changes do not alter existing functionalities but improve the structure and clarity of the code.

Changes

File	Change Summary
conf/pika.conf	Added new configuration parameter: best-delete-min-ratio : 10.
include/acl.h	Updated constructor signature and method signature for EqualChannel for formatting consistency.
include/pika_client_conn.h	Added new method: void InitUser(). Formatted member function definitions in TimeStat struct.
src/acl.cc	Minor formatting changes in InitLimitUser and SetUser methods for consistency.
src/pika_client_conn.cc	Introduced InitUser method, modified AuthRequired method for logging, and reformatted comments.

Possibly related PRs

• fix: fix user ERR NOAUTH Authentication required #2939: This PR is directly related to the main PR as it also introduces the best-delete-min-ratio configuration parameter in the conf/pika.conf file, which is relevant to the compaction strategy.

Suggested reviewers

• Mixficsol

Poem

In the land of code where rabbits play,
A new config shines bright today.
With InitUser now in sight,
Our Pika hops to new heights!
Formatting tidy, all in line,
Hooray for changes, oh so fine! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 441ce65 and a00cba1.

📒 Files selected for processing (1)

• conf/pika.conf (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• conf/pika.conf

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/pika_client_conn.cc (1)

555-556: Consider adjusting log levels for authentication checks

The current implementation uses INFO level for authentication debugging. Consider using DEBUG level for these checks to avoid log spam in production environments.

-  LOG(INFO) << "IsAuthed: " << IsAuthed();
-  LOG(INFO) << "user_->Flags(): " << user_->Flags();
+  LOG(DEBUG) << "IsAuthed: " << IsAuthed();
+  LOG(DEBUG) << "user_->Flags(): " << user_->Flags();

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7c155a5 and 441ce65.

📒 Files selected for processing (5)

• conf/pika.conf (1 hunks)
• include/acl.h (3 hunks)
• include/pika_client_conn.h (3 hunks)
• src/acl.cc (1 hunks)
• src/pika_client_conn.cc (5 hunks)

✅ Files skipped from review due to trivial changes (2)

• include/acl.h
• src/acl.cc

🔇 Additional comments (3)

include/pika_client_conn.h (1)

87-87: LGTM: New method for user initialization

The addition of InitUser() as a public method aligns well with the authentication-related changes and follows the class's responsibility of managing client connections.

src/pika_client_conn.cc (1)

543-551: LGTM: Clear and correct user initialization logic

The implementation properly:

1. Checks blacklist configuration to determine user type
2. Sets appropriate user based on blacklist presence
3. Correctly initializes authentication state based on user flags

conf/pika.conf (1)

694-694: Verify relevance of new configuration parameter

The addition of best-delete-min-ratio appears unrelated to the PR's objective of fixing authentication issues. Please clarify the relationship between this configuration parameter and the authentication fix.