Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add macos test #2943

Closed
wants to merge 8 commits into from
Closed

feat:add macos test #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cb60cfe
feat:add macos test
brother-jin Nov 4, 2024
c36fd12
fixci
brother-jin Nov 5, 2024
caebd7a
fixci
brother-jin Nov 5, 2024
bb02d3a
fixci
brother-jin Nov 5, 2024
087cd0c
fixci
brother-jin Nov 5, 2024
e1babbf
fixci
brother-jin Nov 5, 2024
f59c753
fixci
brother-jin Nov 5, 2024
04d5d0e
fixci
brother-jin Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions .github/workflows/pika.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,18 @@ jobs:
with:
key: macos-13

- name: Uninstall Existing zlib
run: |
# Uninstall existing zlib to avoid conflicts
brew uninstall --ignore-dependencies zlib || true

- name: Reinstall New zlib
run: |
# Install new zlib version
brew install zlib
# Verify installation and path
brew link --force zlib

- name: Install Deps
run: |
brew update
Expand Down Expand Up @@ -204,21 +216,20 @@ jobs:
./pikatests.sh all clean

- name: Start codis, pika master and pika slave
working-directory: ${{ github.workspace }}
working-directory: ${{ github.workspace }}/build
run: |
cd tests/integration/
chmod +x start_master_and_slave.sh
./start_master_and_slave.sh
chmod +x start_codis.sh
./start_codis.sh
chmod +x ../tests/integration/start_master_and_slave.sh
../tests/integration/start_master_and_slave.sh
chmod +x ../tests/integration/start_codis.sh
../tests/integration/start_codis.sh


- name: Run Go E2E Tests
working-directory: ${{ github.workspace }}
working-directory: ${{ github.workspace }}/build
run: |
cd tests/integration/
cd ../../tests/integration/
chmod +x integrate_test.sh
# sh integrate_test.sh
sh integrate_test.sh
Comment on lines +228 to +232
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix incorrect directory navigation in Go E2E tests.

The cd ../../tests/integration/ command from the build directory would navigate outside the workspace. This should be adjusted to use the correct relative path.

Apply this fix:

  working-directory: ${{ github.workspace }}/build
  run: |
-   cd ../../tests/integration/
+   cd ../tests/integration/
    chmod +x integrate_test.sh
    sh integrate_test.sh

Committable suggestion skipped: line range outside the PR's diff.


build_pika_image:
name: Build Pika Docker image
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/start_codis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ sed -i '' -e 's|databases : 1|databases : 2|' -e 's|port : 9221|port : 8001|' -e
#ensure both master and slave are ready
sleep 10

pwd
echo "$(pwd)"

cd ../codis
make

Expand Down
Loading