fix: Revert "fix version compare error in ZSetsScoreKeyComparatorImpl" #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
approved these changes
Apr 8, 2024
chejinge
approved these changes
Apr 8, 2024
|
看下这个 Operator build ci 为啥失败了 |
Let’s take a look at why this Operator build ci failed. |
wangshao1
force-pushed
the
bugfix/revert_fix_version_compare
branch
from
7eaef1a to
fd0ef49
Compare
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
…nAtomFoundation#2339)" (OpenAtomFoundation#2583) This reverts commit 240b7f1. Co-authored-by: wangshaoyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e787eff.
之前发现zsetscorekeycomparatorimpl中直接通过字典序比较version，在小端环境下结果是错误的，提了issue：https://github.com/OpenAtomFoundation/pika/issues/2338，也提了pr修复。
但修复后comparator结果虽然是正确的，但是跟之前不兼容，所以rocksdb在compact时会报错“Compaction sees out-of-order keys.”
所以暂时先回滚该commit，优先保证数据兼容性。