fix(eslint/js): allow unused var when leading underscore (#61)

OpenAlly · Jan 5, 2025 · a0b0d43 · a0b0d43
1 parent 4232e93
commit a0b0d43
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/eslint/src/rules/variables.ts b/src/eslint/src/rules/variables.ts
@@ -27,5 +27,13 @@ export default {
   "no-undefined": "off",
 
   // See: https://eslint.org/docs/rules/no-unused-vars
-  "no-unused-vars": ["error", { "ignoreRestSiblings": true }]
+  "no-unused-vars": ["error", {
+    "args": "all",
+    "argsIgnorePattern": "^_",
+    "caughtErrors": "all",
+    "caughtErrorsIgnorePattern": "^_",
+    "destructuredArrayIgnorePattern": "^_",
+    "varsIgnorePattern": "^_",
+    "ignoreRestSiblings": true
+  }]
 };
diff --git a/src/eslint/test/fixtures/pass.ts b/src/eslint/test/fixtures/pass.ts
@@ -1,2 +1,6 @@
 const foo: string = "bar";
 console.log(foo);
+function _shouldPassEvenIfNotUsedDueToLeading_(_boo: any) {
+  console.log("bar");
+}
+const _shadow = "foo";