Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue989 implement BatchJobProgressListener.onApplicationEnd to filter the stages to only log long-running stages #365

Merged
merged 2 commits into from
Jan 15, 2025
Merged

issue989 implement BatchJobProgressListener.onApplicationEnd to filter the stages to only log long-running stages #365

merged 2 commits into from
Jan 15, 2025

Conversation

ElienVandermaesenVITO
Copy link
Contributor

@ElienVandermaesenVITO
issue989 implement BatchJobProgressListener.onApplicationEnd to filte…
28e92a5 
…r the stages to only log long-running stages
@ElienVandermaesenVITO ElienVandermaesenVITO marked this pull request as draft January 14, 2025 10:33
@ElienVandermaesenVITO ElienVandermaesenVITO marked this pull request as ready for review January 14, 2025 12:30
@jdries jdries merged commit fe4c068 into develop Jan 15, 2025
1 check failed
@jdries
Copy link
Contributor

jdries commented Jan 15, 2025

Merging this one as it looks good.
One area of doubt is if we should still print something at the start or end of a stage, just for progress monitoring.
Other question will be if it's perhaps better to print a single multi-line log at the end, but not sure if that will play nice. To be evaluated on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdries jdries jdries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElienVandermaesenVITO @jdries