-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tsystems 211 upgrade spring boot to 3.3.x #709
Tsystems 211 upgrade spring boot to 3.3.x #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @tkuzynow, I changed the base-branch to have a better diff (to the one I already reviewed).
Just a question regarding src/test/java/de/caritas/cob/userservice/api/OrganizerIT.java there you added a Disabled
The rest looks fine.
Thanks,
Patric
import org.springframework.test.context.ActiveProfiles; | ||
|
||
@SpringBootTest | ||
@ActiveProfiles("testing") | ||
@Disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why Disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring Boot 3.3.X introduced some refinements in Ahead-of-Time (AOT) processing, which affects how beans are detected and registered. The error was that AOT processing could not resolve a constructor for MongoClient, which was not even used explicitly in this test.
I investigated and spent quite some time on it, but could not find any working fix for this test in reasonable time.
This was clearly an issue with the test, and not the application.
Moreover this feature is not being used in our codebase (this is related to the old-way appointments were handled for caritas, so I decided to mark it as disabled to proceed with more important tests on the cluster).
To be more specific:
The test itself works (from IDE), but the process-aot maven phase was throwing the exception. This was executed only when you run mvn install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @tkuzynow, looks fine what I can see.
…-to-3.3.X' into TSYSTEMS-211-upgrade-spring-boot-to-3.3.X
|
Fixes #
Proposed Changes