fix: informal language

Onlineberatung · Jan 4, 2024 · 401d53c · 401d53c
1 parent d40b088
commit 401d53c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/de/caritas/cob/mailservice/api/service/TranslationService.java b/src/main/java/de/caritas/cob/mailservice/api/service/TranslationService.java
@@ -104,8 +104,11 @@ private String fetchTranslationsAsString(String languageCode, Dialect dialect) {
   }
 
   private String fetchDefaultTranslations(String translationComponentName, String languageCode, Dialect dialect) {
+    String translationFilename = getTranslationFilename(
+        translationComponentName + "." + languageCode
+            + TranlationMangementServiceApiClient.getDialectSuffix(dialect));
     var inputStream = TranslationService.class.getResourceAsStream(
-        getTranslationFilename(translationComponentName + "." + languageCode + tranlationMangementServiceApiClient.getDialectSuffix(dialect)));
+        translationFilename);
     if (inputStream == null) {
       return "{}";
     }

diff --git a/...java/de/caritas/cob/mailservice/config/apiclient/TranlationMangementServiceApiClient.java b/...java/de/caritas/cob/mailservice/config/apiclient/TranlationMangementServiceApiClient.java
@@ -41,7 +41,7 @@ public String tryFetchTranslationsFromTranslationManagementService(String projec
     return response.getBody();
   }
 
-  public String getDialectSuffix(Dialect dialect) {
+  public static String getDialectSuffix(Dialect dialect) {
     if (dialect == null) {
       return StringUtils.EMPTY;
     }

diff --git a/src/test/java/de/caritas/cob/mailservice/api/controller/MailControllerE2EIT.java b/src/test/java/de/caritas/cob/mailservice/api/controller/MailControllerE2EIT.java
@@ -237,7 +237,7 @@ private void givenAnEmailList(LanguageCode languageCode) {
     var email = new MailDTO();
     email.setEmail(RandomStringUtils.randomAlphanumeric(32));
     email.setTemplate("reassign-confirmation-notification");
-    email.setDialect(Dialect.INFORMAL);
+    email.setDialect(Dialect.FORMAL);
 
     var nameRecipient = new TemplateDataDTO()
         .key("name_recipient")