Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 로그인 상태 관리 및 우측 사이드바 제작 #24

Merged
merged 18 commits into from
Nov 28, 2024
Merged

Conversation

Han-wo
Copy link
Collaborator

@Han-wo Han-wo commented Nov 26, 2024

#️⃣ 이슈

📝 작업 내용

우측 사이드바제작 및 로그인 상태관리 입니다

📸 스크린샷

default.webm

✅ 체크 리스트

  • 적절한 Title 작성
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정
  • 로컬 작동 확인
  • Merge 되는 브랜치 확인

👩‍💻 공유 포인트 및 논의 사항

전역상태 스토어에 저장된 정보로 로그인 상태를 확인하니까 새로고침하면 잠깐 로그인 안되어있을때 컴포넌트가 보이네요
이건 로딩이나 혹은 추후에 캐싱을 이용해서 수정해보겠습니다

@Han-wo Han-wo added 우선순위: MEDIUM New feature or request ✨ FEAT This doesn't seem right labels Nov 26, 2024
@Han-wo Han-wo self-assigned this Nov 26, 2024
@Han-wo Han-wo linked an issue Nov 26, 2024 that may be closed by this pull request
@Han-wo
Copy link
Collaborator Author

Han-wo commented Nov 26, 2024

로그아웃 버튼 위치도 추후에 디자이너 분께서 헤더 만들면 그 쪽으로 바꾸겟습니다

Copy link

@Han-wo Han-wo changed the title feat/22 : 로그인 상태 관리 및 우측 사이드바 제작 feat: 로그인 상태 관리 및 우측 사이드바 제작 Nov 26, 2024
Copy link
Collaborator

@cindycho0423 cindycho0423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테이블 만드는거 되게 어려워보이는데 금방 잘하시네용👍🏻🥳

};

// 초기 자산 값 (1억)
const INITIAL_ASSET = 100_000_000;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 이름 1억으로 바꾸고

  const eok = Math.floor(amount / 100000000);
  const man = Math.floor((amount % 100000000) / 10000);

여기서도 쓰는건 어때용

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!

isNegative ? "text-[#1A00DF]" : "text-[#F12E35]"
}`}
className={clsx("flex items-center", {
"text-[#1A00DF]": isNegative,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 왜 삼항연산자 안쓰구 이렇게 바꾼건지 궁금해용!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clsx 쓸수 있어서 바꿨습니다!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 zustand는 따로 store 폴더에 저장하는게 덜 헷갈릴 것 같아용!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스토어 라기보단 쿠키관련한걸 클라이언트에서 사용하게 할수있는 훅이라 빼놨는데 다음 PR에 옮겨볼게요

@Han-wo Han-wo merged commit 2db8e4c into develop Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ FEAT This doesn't seem right 우선순위: MEDIUM New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

메인페이지 우측 사이드바 제작 및 로그인상태관리
2 participants