Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Add required react-native-onesignal #38

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

jkasten2
Copy link
Member

Description

One Line Summary

Add required yarn add react-native-onesignal and --clean parameter to the setup guide so native modules link correctly.

Related

#21 (comment)

React native doesn't auto link traversed dependencies so
we must directly add it to the project so this happens.
Otherwise you will see an error that the native OneSignal
module could not be found when you run on the device.
Expo may not link in native modules without doing a
full clean rebuild.
@jkasten2 jkasten2 requested review from devpato and rgomezp December 13, 2021 23:50
@rgomezp rgomezp merged commit 2b724d0 into main Dec 14, 2021
@rgomezp rgomezp deleted the docs/add-react-native-onesignal branch December 14, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants