PBXGroups: make sure we're only adding to the top-level group #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes #226 by restricting PBXGroups we add NSE files to.
Details
Motivation: other groups may have an undefined "name" property other than the top level
Fix #226
Motivation
In some cases, other PBXGroups can meet the criteria such as "Pods", or "" (un-named) groups. However, we should not add NSE files to these.
Testing
Manual testing
Tested manually by creating a beta release (
2.0.3-beta.0
) and running an EAS managed build. However, this introduced a new problem described here.Deleting and recreating 1) Distribution certificates and 2) Provisioning profiles via
eas credentials
did the trick.Checklist
Overview
Testing
- Only impacts iOS
Final pass