Fix: Prevent crash with nil HTTPResponse headers #1518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Prevent crash with nil
HTTPResponse
headers by adding fallback to empty dictionary.Details
This PR addresses customer-reported issues regarding the
NSInvalidArgumentException
crash [1] [2].Changes made in Release 5.2.6 introduced response headers getting stored in a dictionary. However, when these headers are nil (for example, due to no internet connection), the request is never actually made, leading to the reported crash.
This PR prevents the crash by adding a fallback to an empty dictionary.
Scope
Changes are limited to the
handleJSONNSURLResponse
method.Testing
Manual testing
Tested turning off wifi on an iPhone 16 Pro simulator running iOS 18.0. With the changes in this PR, the crash is prevented.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is