Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent crash with nil HTTPResponse headers #1518

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Nov 21, 2024

Description

One Line Summary

Prevent crash with nil HTTPResponse headers by adding fallback to empty dictionary.

Details

This PR addresses customer-reported issues regarding the NSInvalidArgumentException crash [1] [2].

Changes made in Release 5.2.6 introduced response headers getting stored in a dictionary. However, when these headers are nil (for example, due to no internet connection), the request is never actually made, leading to the reported crash.

This PR prevents the crash by adding a fallback to an empty dictionary.

Scope

Changes are limited to the handleJSONNSURLResponse method.

Testing

Manual testing

Tested turning off wifi on an iPhone 16 Pro simulator running iOS 18.0. With the changes in this PR, the crash is prevented.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jennantilla jennantilla requested a review from nan-li November 21, 2024 01:26
@jennantilla jennantilla merged commit 73ae2ef into main Nov 21, 2024
3 of 4 checks passed
@jennantilla jennantilla deleted the fix/NSInvalidArgument-Exception branch November 21, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants