Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cd.yml #1378

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Update cd.yml #1378

merged 1 commit into from
Apr 15, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Mar 5, 2024 •
edited
Loading

Use github.events.inputs instead of env for accessing workflow dispatch variables

This change is Reviewable

@emawby
Update cd.yml
0d9481d 
Use github.events.inputs instead of env for accessing workflow dispatch variables
@emawby emawby requested a review from nan-li March 5, 2024 20:37
nan-li
nan-li approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@nan-li nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall I used this to release before, and it did work. I ran into an unrelated issue.

@nan-li nan-li mentioned this pull request Apr 12, 2024
Merged
18 tasks
@nan-li nan-li merged commit a14ac6a into main Apr 15, 2024
4 checks passed
@nan-li nan-li deleted the fix_cd branch April 15, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-li nan-li nan-li approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emawby @nan-li