Skip to content

Commit

Permalink
Move UIApplication+OneSignal from OneSIgnal > OneSignalInAppMessages
Browse files Browse the repository at this point in the history
* This extension on `UIApplication` is only used in the `OneSignalInAppMessages` framework, so there is no need to keep it in the umbrella `OneSignalFramework` framework, which causes errors if only `OneSignalInAppMessages` is tested (without also importing OneSignalFramework).
  • Loading branch information
nan-li committed Jan 28, 2025
1 parent ecdd49a commit 64c25b6
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 15 deletions.
28 changes: 16 additions & 12 deletions iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@
3C0C67242D49469200F80448 /* MockMessagingController.h in Headers */ = {isa = PBXBuildFile; fileRef = 3C0C67212D49469200F80448 /* MockMessagingController.h */; settings = {ATTRIBUTES = (Public, ); }; };
3C0C67252D4946BD00F80448 /* OneSignalCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D17E627026B95002D3A5D /* OneSignalCore.framework */; };
3C0C67262D4946BD00F80448 /* OneSignalCore.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D17E627026B95002D3A5D /* OneSignalCore.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
3C0C67372D49503E00F80448 /* UIApplication+OneSignal.m in Sources */ = {isa = PBXBuildFile; fileRef = 3C0C672F2D49501D00F80448 /* UIApplication+OneSignal.m */; };
3C0C67382D49505700F80448 /* UIApplication+OneSignal.h in Headers */ = {isa = PBXBuildFile; fileRef = 3C0C672E2D49501D00F80448 /* UIApplication+OneSignal.h */; };
3C0EF49E28A1DBCB00E5434B /* OSUserInternalImpl.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3C0EF49D28A1DBCB00E5434B /* OSUserInternalImpl.swift */; };
3C115165289A259500565C41 /* OneSignalOSCore.docc in Sources */ = {isa = PBXBuildFile; fileRef = 3C115164289A259500565C41 /* OneSignalOSCore.docc */; };
3C115171289A259500565C41 /* OneSignalOSCore.h in Headers */ = {isa = PBXBuildFile; fileRef = 3C115163289A259500565C41 /* OneSignalOSCore.h */; settings = {ATTRIBUTES = (Public, ); }; };
Expand Down Expand Up @@ -365,9 +367,6 @@
DE16C14524D3724700670EFA /* OneSignalLifecycleObserver.m in Sources */ = {isa = PBXBuildFile; fileRef = DE16C14324D3724700670EFA /* OneSignalLifecycleObserver.m */; };
DE16C14724D3727200670EFA /* OneSignalLifecycleObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = DE16C14624D3727200670EFA /* OneSignalLifecycleObserver.h */; };
DE16C17024D3989A00670EFA /* OneSignalLifecycleObserver.m in Sources */ = {isa = PBXBuildFile; fileRef = DE16C14324D3724700670EFA /* OneSignalLifecycleObserver.m */; };
DE20425E24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */ = {isa = PBXBuildFile; fileRef = DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */; };
DE20425F24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */ = {isa = PBXBuildFile; fileRef = DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */; };
DE20426024E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */ = {isa = PBXBuildFile; fileRef = DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */; };
DE2D8F452947D85800844084 /* OneSignalExtension.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D17F927026BA3002D3A5D /* OneSignalExtension.framework */; };
DE2D8F4A2947D86200844084 /* OneSignalOutcomes.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D188027037F43002D3A5D /* OneSignalOutcomes.framework */; };
DE3784842888CFF900453A8E /* OneSignalUser.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE69E19B282ED8060090BB3D /* OneSignalUser.framework */; };
Expand Down Expand Up @@ -574,7 +573,6 @@
DEC08B012947D4E900C81DA3 /* OneSignalSwiftInterface.swift in Sources */ = {isa = PBXBuildFile; fileRef = DEC08AFF2947D4E900C81DA3 /* OneSignalSwiftInterface.swift */; };
DEC08B022947D4E900C81DA3 /* OneSignalSwiftInterface.swift in Sources */ = {isa = PBXBuildFile; fileRef = DEC08AFF2947D4E900C81DA3 /* OneSignalSwiftInterface.swift */; };
DECE6F5B28C90821007058EE /* OneSignalOSCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3C115161289A259500565C41 /* OneSignalOSCore.framework */; };
DEE8198D24E21DF000868CBA /* UIApplication+OneSignal.h in Headers */ = {isa = PBXBuildFile; fileRef = DE20425C24E21C1500350E4F /* UIApplication+OneSignal.h */; };
DEF5CCF52539321A0003E9CC /* AppDelegate.m in Sources */ = {isa = PBXBuildFile; fileRef = DEF5CCF42539321A0003E9CC /* AppDelegate.m */; };
DEF5CCFB2539321A0003E9CC /* ViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = DEF5CCFA2539321A0003E9CC /* ViewController.m */; };
DEF5CCFE2539321A0003E9CC /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = DEF5CCFC2539321A0003E9CC /* Main.storyboard */; };
Expand Down Expand Up @@ -1282,6 +1280,8 @@
3C0C67162D493E5A00F80448 /* IAMTestHelpers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = IAMTestHelpers.swift; sourceTree = "<group>"; };
3C0C67212D49469200F80448 /* MockMessagingController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MockMessagingController.h; sourceTree = "<group>"; };
3C0C67222D49469200F80448 /* MockMessagingController.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MockMessagingController.m; sourceTree = "<group>"; };
3C0C672E2D49501D00F80448 /* UIApplication+OneSignal.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIApplication+OneSignal.h"; sourceTree = "<group>"; };
3C0C672F2D49501D00F80448 /* UIApplication+OneSignal.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UIApplication+OneSignal.m"; sourceTree = "<group>"; };
3C0EF49D28A1DBCB00E5434B /* OSUserInternalImpl.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = OSUserInternalImpl.swift; sourceTree = "<group>"; };
3C115161289A259500565C41 /* OneSignalOSCore.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = OneSignalOSCore.framework; sourceTree = BUILT_PRODUCTS_DIR; };
3C115163289A259500565C41 /* OneSignalOSCore.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = OneSignalOSCore.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1587,8 +1587,6 @@
CACBAAAB218A662B000ACAA5 /* WebKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = WebKit.framework; path = System/Library/Frameworks/WebKit.framework; sourceTree = SDKROOT; };
DE16C14324D3724700670EFA /* OneSignalLifecycleObserver.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OneSignalLifecycleObserver.m; sourceTree = "<group>"; };
DE16C14624D3727200670EFA /* OneSignalLifecycleObserver.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = OneSignalLifecycleObserver.h; sourceTree = "<group>"; };
DE20425C24E21C1500350E4F /* UIApplication+OneSignal.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIApplication+OneSignal.h"; sourceTree = "<group>"; };
DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = "UIApplication+OneSignal.m"; sourceTree = "<group>"; };
DE3CD2FE270FA9F200A5BECD /* OSOutcomes.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OSOutcomes.m; sourceTree = "<group>"; };
DE51DDE3294262AB0073D5C4 /* OSRemoteParamController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OSRemoteParamController.m; sourceTree = "<group>"; };
DE51DDE4294262AB0073D5C4 /* OSRemoteParamController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSRemoteParamController.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -2148,6 +2146,15 @@
path = OneSignalInAppMessagesTests;
sourceTree = "<group>";
};
3C0C67302D49501D00F80448 /* Categories */ = {
isa = PBXGroup;
children = (
3C0C672E2D49501D00F80448 /* UIApplication+OneSignal.h */,
3C0C672F2D49501D00F80448 /* UIApplication+OneSignal.m */,
);
path = Categories;
sourceTree = "<group>";
};
3C115162289A259500565C41 /* OneSignalOSCore */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -2578,8 +2585,6 @@
CA1A6E6820DC2E31001C41B9 /* OneSignalDialogController.m */,
CA1A6E6D20DC2E73001C41B9 /* OneSignalDialogRequest.h */,
CA1A6E6E20DC2E73001C41B9 /* OneSignalDialogRequest.m */,
DE20425C24E21C1500350E4F /* UIApplication+OneSignal.h */,
DE20425D24E21C2C00350E4F /* UIApplication+OneSignal.m */,
);
name = Categories;
sourceTree = "<group>";
Expand Down Expand Up @@ -2966,6 +2971,7 @@
DEBAAE4E2A42159000BF2C1C /* Model */,
DEBAAE4D2A42158600BF2C1C /* Controller */,
DEBAAE4C2A42157B00BF2C1C /* UI */,
3C0C67302D49501D00F80448 /* Categories */,
DEBAAE2A2A4211DA00BF2C1C /* OneSignalInAppMessages.h */,
DEBAAE982A42179A00BF2C1C /* OneSignalInAppMessages.m */,
DEBAAE962A42178800BF2C1C /* OSInAppMessagingDefines.h */,
Expand Down Expand Up @@ -3179,7 +3185,6 @@
9124123D1E73342200E41FD7 /* UIApplicationDelegate+OneSignal.h in Headers */,
7AF9865324451F3900C36EAE /* OSFocusCallParams.h in Headers */,
DE7D18DD2703B44B002D3A5D /* OSFocusRequests.h in Headers */,
DEE8198D24E21DF000868CBA /* UIApplication+OneSignal.h in Headers */,
7AECE59C23675F5700537907 /* OSFocusTimeProcessorFactory.h in Headers */,
7AECE59A23674ADC00537907 /* OSUnattributedFocusTimeProcessor.h in Headers */,
9124121D1E73342200E41FD7 /* OneSignalJailbreakDetection.h in Headers */,
Expand Down Expand Up @@ -3314,6 +3319,7 @@
DEBAAE622A42175A00BF2C1C /* OSInAppMessageController.h in Headers */,
DEBAAE662A42175A00BF2C1C /* OSDynamicTriggerController.h in Headers */,
DEBAAE642A42175A00BF2C1C /* OSTriggerController.h in Headers */,
3C0C67382D49505700F80448 /* UIApplication+OneSignal.h in Headers */,
DEBAAE562A42174A00BF2C1C /* OSInAppMessageViewController.h in Headers */,
DEBAAEB82A4381AE00BF2C1C /* OSInAppMessageMigrationController.h in Headers */,
DEBAAE7E2A42176800BF2C1C /* OSInAppMessageDisplayStats.h in Headers */,
Expand Down Expand Up @@ -4256,7 +4262,6 @@
7AFE856B2368DDB80091D6A5 /* OSFocusCallParams.m in Sources */,
7AECE59E23675F6300537907 /* OSFocusTimeProcessorFactory.m in Sources */,
7A93269C25AF4F0200BBEC27 /* OSPendingCallbacks.m in Sources */,
DE20425E24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */,
7AECE59623674AB700537907 /* OSUnattributedFocusTimeProcessor.m in Sources */,
3C448B9E2936ADFD002F96BC /* OSBackgroundTaskHandlerImpl.m in Sources */,
7AECE59023674A9700537907 /* OSAttributedFocusTimeProcessor.m in Sources */,
Expand Down Expand Up @@ -4383,7 +4388,6 @@
7A674F1C2360D82E001F9ACD /* OSBaseFocusTimeProcessor.m in Sources */,
7AFE856C2368DDB80091D6A5 /* OSFocusCallParams.m in Sources */,
7A93269D25AF4F0200BBEC27 /* OSPendingCallbacks.m in Sources */,
DE20425F24E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */,
3C448B9F2936ADFD002F96BC /* OSBackgroundTaskHandlerImpl.m in Sources */,
912412371E73342200E41FD7 /* OneSignalTrackIAP.m in Sources */,
7AECE59123674A9700537907 /* OSAttributedFocusTimeProcessor.m in Sources */,
Expand Down Expand Up @@ -4466,7 +4470,6 @@
7AECE59223674A9700537907 /* OSAttributedFocusTimeProcessor.m in Sources */,
912412341E73342200E41FD7 /* OneSignalTracker.m in Sources */,
03866CBD2378A33B0009C1D8 /* OutcomeIntegrationTests.m in Sources */,
DE20426024E21C2C00350E4F /* UIApplication+OneSignal.m in Sources */,
03389F691FB548A0006537F0 /* OneSignalTrackFirebaseAnalyticsOverrider.m in Sources */,
7ABAF9D62457D3FF0074DFA0 /* ChannelTrackersTests.m in Sources */,
4529DED51FA823B900CEAB1D /* TestHelperFunctions.m in Sources */,
Expand Down Expand Up @@ -4660,6 +4663,7 @@
DEBAAE602A42175A00BF2C1C /* OSDynamicTriggerController.m in Sources */,
DEBAAE8A2A42176800BF2C1C /* OSInAppMessageInternal.m in Sources */,
DE70EB932A5CACF5003166D3 /* OneSignalWebView.m in Sources */,
3C0C67372D49503E00F80448 /* UIApplication+OneSignal.m in Sources */,
DEBAAE872A42176800BF2C1C /* OSInAppMessageBridgeEvent.m in Sources */,
DEBAAE892A42176800BF2C1C /* OSInAppMessageClickEvent.m in Sources */,
DEBAAE842A42176800BF2C1C /* OSInAppMessageDisplayStats.m in Sources */,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
*/

#import "OSMessagingController.h"
#import "UIApplication+OneSignal.h" // Previously imported via "OneSignalHelper.h"
#import "NSDateFormatter+OneSignal.h" // Previously imported via "OneSignalHelper.h"
#import "UIApplication+OneSignal.h"
#import "NSDateFormatter+OneSignal.h"
#import <OneSignalCore/OneSignalCore.h>
#import "OSInAppMessageClickResult.h"
#import "OSInAppMessageClickEvent.h"
Expand Down
1 change: 0 additions & 1 deletion iOS_SDK/OneSignalSDK/Source/OneSignalLifecycleObserver.m
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ of this software and associated documentation files (the "Software"), to deal
#import "OneSignalCommonDefines.h"
#import "OneSignalTracker.h"
#import <OneSignalLocation/OneSignalLocationManager.h>
#import "UIApplication+OneSignal.h"

@implementation OneSignalLifecycleObserver

Expand Down

0 comments on commit 64c25b6

Please sign in to comment.