Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ultimate-addons-for-gutenberg (now Spectra) #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updates for ultimate-addons-for-gutenberg (now Spectra) #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config-index.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
<item id="stackable-ultimate-gutenberg-blocks" override_local="true">Stackable - Gutenberg Blocks</item>
<item id="subscriptio">Subscriptio</item>
<item id="the-events-calendar" override_local="true">The Events Calendar</item>
<item id="ultimate-addons-for-gutenberg" override_local="true">Spectra</item>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diiegopereira, I saw your comment in compsupp-6801, that the Spectra plugin has a local WPML config file.

Beware that if we override the local file, we may loose some local configurations if it was not synced on the remote one.

Can you make sure the local and remote config files are in sync?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strategio it seems that we have several differences between our remote file and the one included in the plugin: https://www.diffchecker.com/ArriH1zI/

I was trying to manually update the remote file by adding the differences to it. But I found some parts that can generate conflicts. E.g. in the remote file, the string is registered using xPath, but in the plugin file, it is registered using "key" (or a different xPath that belongs to the same string).

What would be the correct way to sync both files? Should we use what's included in the plugin, which looks more up-to-date? Is there a problem with a string being registered twice (key + xPath, or 2 different xPath for the same string)?

Copy link
Member

@strategio strategio Jun 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diiegopereira, let me share some elements:

  1. String IDs (i.e. strings names) are based on the block name and the text content, we make a hash of that (see here). In short, strings are unique to block type and content. If we have twice the same content inside a block, we'll register only 1 string. So we don't risk to have duplicated strings or wrong string IDs inside blocks (note that this is not true for other page builders integration).

  2. If you see that the plugin's local XML config looks more up-to-date than the remote one, it means that the author is maintaining his config (even not fully). At least, he probably does that more than us.

With all that said, I think we have 2 options:

  1. Take real ownership of the config: First, we need to merge the local config into the remote one (as you started to do), and then inform the author that the remote configuration will now take precedence. If he wants to change/add blocks in the future, he will need to open a PR here.

  2. Let the author take care of his config, and inform him about the issue we found (and perhaps ask him for a campaign of re-testing on his plugin).

I'll let you check what could be the best option.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @strategio! I think we should contact the author and discuss the best option. Let's continue on youtrack for now.

<item id="ultimate-addons-for-gutenberg" override_local="true">Ultimate Addons for Gutenberg</item>
<item id="ultimate-member" override_local="true">Ultimate Member</item>
<item id="uncode-js_composer" override_local="true">Uncode Page Builder (Visual Composer)</item>
Expand Down
1 change: 1 addition & 0 deletions ultimate-addons-for-gutenberg/wpml-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<gutenberg-blocks>
<gutenberg-block type="uagb/advanced-heading" translate="1">
<xpath>//*[self::h1 or self::h2 or self::h3 or self::h4 or self::h5 or self::h6]</xpath>
<xpath>//div/div[@class="uagb-heading-text"]</xpath>
<xpath>//div/p[@class="uagb-desc-text"]</xpath>
<key name="customUrl"/>
</gutenberg-block>
Expand Down