Change/override plant entity name and option to hide species #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olen
reviewed
Apr 5, 2024
src/flower-card.ts
Outdated
| @@ -36,6 +36,10 @@ export default class FlowerCard extends LitElement { | |||
| this._hass = hass; | |||
| this.stateObj = this.config?.entity ? hass.states[this.config.entity] : undefined; | |||
|
|
|||
| if (this.config?.name) { | |||
| this.stateObj.attributes.friendly_name = this.config.name; | |||
There was a problem hiding this comment.
I don't really like to overwrite the values in the original object, as it might cause confusion in other parts of the code or while debugging other issues.
So I'd rather do it the other way. If config.name is not set, set it to friendly_name and then display config.name instead.
There was a problem hiding this comment.
Thanks for the feedback, I already noticed some strange behavior due to overriding the original object.
I've changed the code to display name instead of friendly_name and use friendly_name if name is not set.
Please review the changed and cherry-pick, as the branches are conflicted now.
|
Thanks. |
|
If the issues mentioned above is fixed, I'll look at merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature request from #98
Also adds an option to hide the species (which may be very long text and disturb dashboards with many small cards)