Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved ui of testimonal #194

Merged
merged 4 commits into from
Jan 29, 2025
Merged

improved ui of testimonal #194

merged 4 commits into from
Jan 29, 2025

Conversation

msv6264
Copy link
Contributor

@msv6264 msv6264 commented Jan 26, 2025

Related Issue

Fixes #178

Description

added dark mode to testimonial page

Type of PR

  • Bug fix
  • [✅ ] Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2025-01-27 005613

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scd-profile-score ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 9:01am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Ojas-Arora
Copy link
Owner

Ojas-Arora commented Jan 27, 2025

@msv6264 Black colour of name is not seen in Dark Mode and make a total of 6 cards in this page and don;t remove the hovering effect of the card done before .

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 28, 2025

@Ojas-Arora ok, i will update the changes

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 28, 2025

@Ojas-Arora I have updated the changes, and after branch updation there are 9 cards in testimonal page.

@Ojas-Arora
Copy link
Owner

@msv6264 Update Branch and Ready to merge.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 28, 2025

@Ojas-Arora updated the branch, do i need to update main branch also?

@Ojas-Arora
Copy link
Owner

@msv6264 Updation not done correctly , kindly check as latest updation of about us hasn't been added.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 29, 2025

@Ojas-Arora

Screenshot 2025-01-29 093633

Terminal is showing branch is up to date

@Ojas-Arora
Copy link
Owner

@msv6264 The Latest Deployment merged has a scroll to top button present in ti but in Yours It's not present . Check either Some issue of Branch Updation or make a new Pr for that with Updated Branch so that changes can be reflected.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 29, 2025

@Ojas-Arora Now the changes are updated please check.

Copy link
Owner

@Ojas-Arora Ojas-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Ojas-Arora Ojas-Arora merged commit 72522de into Ojas-Arora:main Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement of ui
2 participants