Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove begin your journey #17

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

msv6264
Copy link
Contributor

@msv6264 msv6264 commented Dec 31, 2024

Related Issue

Fixes #15

Description

Note: This PR depends on the changes in PR #16 and #5. Please merge that PR first to ensure this one works as expected.
Removed the "Begin your journey" button from the login page as it was redundant, with both the "Begin your journey" and "Register" buttons leading to the same login page. The "Register" button has been kept as the primary call-to-action for user registration, streamlining the user flow and improving clarity for users.

Type of PR

  • [✅] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2025-01-01 004327

Checklist:

  • [✅] I have performed a self-review of my code
  • [✅] I have read and followed the Contribution Guidelines.
  • [✅] I have tested the changes thoroughly before submitting this pull request.
  • [✅] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [✅] I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scd-profile-score ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 4:33pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 1, 2025

Hi @Ojas-Arora , I’ve converted this PR to a draft since it depends on PR #5 and #16 . Once that PR is merged, I’ll rebase this branch and mark it as ready for review. Thank you!

@msv6264 msv6264 marked this pull request as ready for review January 3, 2025 16:08
@Ojas-Arora
Copy link
Owner

image
@msv6264 In deployment begin your journey has not been fixed. Check either branch has not been updated or This has not been done. Do check this.

@Ojas-Arora
Copy link
Owner

@msv6264 Kindly check again as this has not been done

@Ojas-Arora
Copy link
Owner

Ojas-Arora commented Jan 3, 2025

@msv6264 Work is done just remove the Draft Ready to merge.

@msv6264 msv6264 marked this pull request as ready for review January 3, 2025 16:35
@msv6264
Copy link
Contributor Author

msv6264 commented Jan 3, 2025

I have removed the draft, thank you

Copy link
Owner

@Ojas-Arora Ojas-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@Ojas-Arora Ojas-Arora merged commit af7832e into Ojas-Arora:main Jan 3, 2025
2 checks passed
@Ojas-Arora Ojas-Arora added the done label Jan 8, 2025
@msv6264 msv6264 deleted the fix/remove-begin-your-journey branch January 10, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Begin your journey and register has same page
2 participants