pipeline to check formatting and errors #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenPtr
reviewed
Nov 26, 2024
| - name: Install dependencies with pnpm | ||
| run: pnpm install | ||
|
|
||
| - name: Lint code with ESLint |
There was a problem hiding this comment.
- If ESLint returns feedback about the code format, will the job fail?
- Do the formatting rules need to be specified anywhere?
There was a problem hiding this comment.
Yes, if it encounters an error in the format, the job will fail. Also, you need to install ESLint in your code. Here's a reference you can check: ESLint Integration Tutorial.
There was a problem hiding this comment.
I use prettier not sure if this will break from that, do we really need formatting check and can we use prettier instead if we're checking just formatting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline to check formatting and errors in pitchlake ui