feat: add indexer metadata table + model #17
Closed
+255
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwkang1998
force-pushed
the
feat/indexer-metadata
branch
from
323fc22 to
c99f6e1
Compare
ametel01
reviewed
Dec 10, 2024
| async fn set_is_backfilling(&self, is_backfilling: bool) -> Result<(), ModelError> { | ||
| let result = sqlx::query( | ||
| r#" | ||
| UPDATE indexer_metadata |
There was a problem hiding this comment.
In all this UPDATE are you not using WHERE intentionally? Without it seems that you want to update all the rows on the table?
There was a problem hiding this comment.
in this case, yes. Since there can only (and should only) be one row for this table, this should be acceptable.
If you foresee some cases where this might be held false, do tell me about it.
Add metadata table to allow indexer to track indexing progress and schedule backfilling tasks
cwkang1998
force-pushed
the
feat/indexer-metadata
branch
from
c99f6e1 to
60bdaca
Compare
|
LGTM, just need to make the CI check pass |
|
Due to some changes to the code, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metadata table to allow indexer to track indexing progress and
schedule backfilling tasks