Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fx-core): split scaffold question models #12852

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from

feat: up

80e718d
Select commit
Loading
Failed to load commit list.
Draft

refactor(fx-core): split scaffold question models #12852

feat: up
80e718d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 5, 2024 in 0s

89.51% (-0.55%) compared to fd8dfe6

View this Pull Request on Codecov

89.51% (-0.55%) compared to fd8dfe6

Details

Codecov Report

Attention: Patch coverage is 28.47896% with 221 lines in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (fd8dfe6) to head (80e718d).
Report is 68 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/fx-core/src/question/refactor/createVsc.ts 9.33% 204 Missing ⚠️
...component/generator/templates/templateGenerator.ts 38.88% 11 Missing ⚠️
packages/fx-core/src/ui/visitor.ts 64.28% 1 Missing and 4 partials ⚠️
packages/cli/src/userInteraction.ts 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12852      +/-   ##
==========================================
- Coverage   90.05%   89.51%   -0.55%     
==========================================
  Files         577      580       +3     
  Lines       34327    34704     +377     
  Branches     6829     6805      -24     
==========================================
+ Hits        30914    31064     +150     
- Misses       1507     1724     +217     
- Partials     1906     1916      +10     
Files with missing lines Coverage Δ
packages/fx-core/src/question/constants.ts 96.02% <100.00%> (+<0.01%) ⬆️
packages/fx-core/src/question/create.ts 90.57% <100.00%> (+0.04%) ⬆️
packages/fx-core/src/question/templates.ts 100.00% <100.00%> (ø)
packages/cli/src/userInteraction.ts 86.95% <80.00%> (ø)
packages/fx-core/src/ui/visitor.ts 86.19% <64.28%> (-1.63%) ⬇️
...component/generator/templates/templateGenerator.ts 77.27% <38.88%> (-14.89%) ⬇️
...ackages/fx-core/src/question/refactor/createVsc.ts 9.33% <9.33%> (ø)

... and 20 files with indirect coverage changes