Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlook](NAA) add testing guidance to FAQ #4997

Merged
merged 7 commits into from
Jan 31, 2025
Merged

[Outlook](NAA) add testing guidance to FAQ #4997

merged 7 commits into from
Jan 31, 2025

Conversation

davidchesnut
Copy link
Member

Adding testing guidance for NAA add-ins for Outlook on Windows versions.

Copy link
Contributor

Learn Build status updates of commit da96626:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@lindalu-MSFT lindalu-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify line 257 (unedited) should be heading 2? I just noticed when I was previewing that it seems out of place. Should this be heading 3 under Developer Questions?

Copy link
Contributor

Learn Build status updates of commit 12c8624:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit ef15c4c:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 61e5a10:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@davidchesnut
Copy link
Member Author

Can you verify line 257 (unedited) should be heading 2? I just noticed when I was previewing that it seems out of place. Should this be heading 3 under Developer Questions?

yes, fixed it.


#### Test fallback code for Outlook on Windows "about:blank" bug

Outlook 2016 and 2019 on Windows have a bug when using WebView2. MSAL v3 will detect that NAA is not available and attempt to open a dialog from the task pane to sign in the user. MSAL calls `window.open` with `about:blank`, but Outlook does not handle this correctly and displays an error to the user.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebView2 supports about:blank, it is IE that does not support it

#### Test fallback code for Outlook on Windows "about:blank" bug

Outlook 2016 and 2019 on Windows have a bug when using WebView2. MSAL v3 will detect that NAA is not available and attempt to open a dialog from the task pane to sign in the user. MSAL calls `window.open` with `about:blank`, but Outlook does not handle this correctly and displays an error to the user.
We provided sample code to work around this by using the Office dialog API to successfully sign in the user. For more information, see [Outlook add-in with SSO using nested app authentication](https://github.com/OfficeDev/Office-Add-in-samples/tree/main/Samples/auth/Outlook-Add-in-SSO-NAA), and specifically the **Fallback code** section of the readme.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to reference the IE sample, since this bug only applies to IE.

Copy link
Contributor

Learn Build status updates of commit 8065a0b:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@davidchesnut davidchesnut added the Status: Do Not Merge Do Not Merge label Jan 28, 2025
@davidchesnut davidchesnut removed the Status: Do Not Merge Do Not Merge label Jan 31, 2025
Copy link
Contributor

Learn Build status updates of commit afbd85e:

✅ Validation status: passed

File Status Preview URL Details
docs/outlook/faq-nested-app-auth-outlook-legacy-tokens.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@davidchesnut davidchesnut merged commit 344bc3c into main Jan 31, 2025
2 checks passed
@davidchesnut davidchesnut deleted the davech-5 branch January 31, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants