[Sample Update] Added changes for meeting participants events in meetings notifications sample #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChetanSharma-msft
added
the
DO NOT MERGE
ChetanSharma-msft
changed the title
|
Doc bug link: MicrosoftDocs/msteams-docs#9183 |
ChetanSharma-msft
requested changes
Aug 9, 2023
| { | ||
| "name": "ChannelMeetingParticipant.Read.Group", | ||
| "type": "Delegated" | ||
| } |
There was a problem hiding this comment.
Not required, remove it.
| if (turnContext.Activity.Name == "application/vnd.microsoft.meetingParticipantJoin") | ||
| { | ||
| await turnContext.SendActivityAsync(MessageFactory.Attachment(createAdaptiveCardInvokeResponseAsync(userName, "has joined the meeting."))); | ||
| } |
There was a problem hiding this comment.
Add proper spacing and alignments.
Pawank-MSFT
approved these changes
Oct 5, 2023
rm3f
approved these changes
Oct 5, 2023
rm3f
approved these changes
Oct 10, 2023
rm3f
approved these changes
Oct 17, 2023
| /// <returns></returns> | ||
| protected override async Task OnTeamsMeetingParticipantsJoinAsync(MeetingParticipantsEventDetails meeting, ITurnContext<IEventActivity> turnContext, CancellationToken cancellationToken) | ||
| { | ||
| await turnContext.SendActivityAsync(MessageFactory.Attachment(createAdaptiveCardInvokeResponseAsync(meeting.Members[0].User.Name, " has joined the meeting."))); |
There was a problem hiding this comment.
message should be " joined the meeting." to match the other event which says " left the meeting."
|
Executed build Pipeline run: |
ChetanSharma-msft
approved these changes
Oct 17, 2023
Jegadeesh-MSFT
removed
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.