Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the samples #1516

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Fixed the samples #1516

merged 7 commits into from
Jan 6, 2025

Conversation

Pawank-MSFT
Copy link
Collaborator

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated 3 comments.

Files not reviewed (6)
  • samples/graph-appcatalog-lifecycle/csharp/TeamsApp/appPackage/manifest.json: Language not supported
  • samples/graph-activity-feed/csharp/ActivityFeedNotification/Views/Shared/TeamNotification.cshtml: Evaluated as low risk
  • samples/app-complete-sample/csharp/AppCompleteSample/src/dialogs/RootDialog.cs: Evaluated as low risk
  • samples/graph-rsc/csharp/RSCDemo/Controllers/HomeController.cs: Evaluated as low risk
  • samples/msgext-action-preview/nodejs/bots/teamsMessagingExtensionsActionPreviewBot.js: Evaluated as low risk
  • samples/bot-tag-mention/csharp/README.md: Evaluated as low risk
Comments suppressed due to low confidence (3)

samples/graph-activity-feed/csharp/ActivityFeedNotification/Helpers/ChatMessageHelper.cs:111

  • The word 'Activtity' should be corrected to 'Activity'.
Subject = "Reservation Activtity:",

samples/graph-activity-feed/csharp/ActivityFeedNotification/Helpers/ChatMessageHelper.cs:63

  • [nitpick] Consider providing a more descriptive error message to help with debugging.
Console.WriteLine($"Error adding message: {ex.Message}");

samples/graph-change-notification/nodejs/dialogs/mainDialog.js:77

  • [nitpick] The method name 'getUserState' should follow camelCase naming convention. Consider renaming it to 'getUserState'.
async getUserState(userStateURL) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • samples/graph-appcatalog-lifecycle/csharp/TeamsApp/appPackage/manifest.json: Language not supported
  • samples/graph-activity-feed/csharp/ActivityFeedNotification/Views/Shared/TeamNotification.cshtml: Evaluated as low risk
  • samples/graph-change-notification/nodejs/dialogs/mainDialog.js: Evaluated as low risk
  • samples/graph-change-notification/nodejs/index.js: Evaluated as low risk
  • samples/graph-rsc/csharp/RSCDemo/Controllers/HomeController.cs: Evaluated as low risk
  • samples/msgext-action-preview/nodejs/bots/teamsMessagingExtensionsActionPreviewBot.js: Evaluated as low risk
Comments suppressed due to low confidence (2)

samples/graph-activity-feed/csharp/ActivityFeedNotification/Helpers/ChatMessageHelper.cs:111

  • Corrected spelling mistake from 'Activtity' to 'Activity'.
Subject = "Reservation Activity:",

samples/bot-tag-mention/nodejs/README.md:174

  • There should not be a space before the period.
Click "Create tag" and provide a name, description, and assign team members to the tag.
@Pawank-MSFT
Copy link
Collaborator Author

Copy link
Contributor

@Jegadeesh-MSFT Jegadeesh-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the given PR comments

Copy link
Contributor

@Jegadeesh-MSFT Jegadeesh-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine !

@Jegadeesh-MSFT
Copy link
Contributor

Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good Approved.

@Harikrishnan-MSFT Harikrishnan-MSFT merged commit 8fdc650 into main Jan 6, 2025
271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants