Create New Sample Msgext Thirdparty Storage Nodejs #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 33 out of 48 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- samples/msgext-thirdparty-storage/nodejs/.env: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.gitignore: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/extensions.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/launch.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/settings.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/tasks.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/appManifest/manifest.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/assets/sample.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/env/.env.local: Language not supported
- samples/msgext-thirdparty-storage/nodejs/infra/azure.bicep: Language not supported
- samples/msgext-thirdparty-storage/nodejs/infra/azure.parameters.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/package.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/public/styles.css: Language not supported
- README.md: Evaluated as low risk
- .github/workflows/build-complete-samples.yml: Evaluated as low risk
Comments suppressed due to low confidence (6)
samples/msgext-thirdparty-storage/nodejs/index.js:25
- [nitpick] The error message could be more descriptive. Consider including more context about the error.
console.error(`\n [onTurnError] unhandled error: ${error}`);
samples/msgext-thirdparty-storage/nodejs/index.js:67
- Remove the duplicate server.use(express.static(path.join(__dirname, 'public'))); line.
server.use(express.static(path.join(__dirname, 'public')));
samples/msgext-thirdparty-storage/nodejs/index.js:60
- Add a missing semicolon at the end of the res.render('./views/CustomForm') line.
res.render('./views/CustomForm')
samples/msgext-thirdparty-storage/nodejs/build.js:12
- [nitpick] The error message could be more descriptive. Consider updating it to: console.log(
Build failed with error: ${e.message});
console.log("Error building:", e.message);
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js:6
- The variable name baseurl should be renamed to baseUrl to follow camelCase convention.
const baseurl = process.env.BaseUrl;
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js:74
- The handleTeamsMessagingExtensionFetchTask method should have a test case to cover the condition where value.messagePayload?.replyToId === '' && value.commandContext === 'thirdParty'.
async handleTeamsMessagingExtensionFetchTask(context, action) {
There was a problem hiding this comment.
Copilot reviewed 33 out of 48 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- samples/msgext-thirdparty-storage/nodejs/.env: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.gitignore: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/extensions.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/launch.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/settings.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/tasks.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/appManifest/manifest.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/assets/sample.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/env/.env.local: Language not supported
- samples/msgext-thirdparty-storage/nodejs/infra/azure.bicep: Language not supported
- samples/msgext-thirdparty-storage/nodejs/infra/azure.parameters.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/package.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/public/styles.css: Language not supported
- .github/workflows/build-complete-samples.yml: Evaluated as low risk
- README.md: Evaluated as low risk
Comments suppressed due to low confidence (8)
samples/msgext-thirdparty-storage/nodejs/index.js:36
- Uncomment the line and update the error message to:
Sorry, something went wrong. Please try again later. Error: ${error}
// await context.sendActivity(`Sorry, it looks like something went wrong. Exception Caught: ${error}`);
samples/msgext-thirdparty-storage/nodejs/index.js:64
- Update the error message to:
The requested route was not found on the server.
res.json({ error: 'Route not found' });
samples/msgext-thirdparty-storage/nodejs/build.js:12
- The error message is too generic. Consider providing a more descriptive error message to help with debugging. For example:
console.error(Build failed with error: ${e.message});
console.log("Error building:", e.message);
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js:6
- The variable name 'baseurl' should be 'baseUrl' to follow camelCase naming conventions.
const baseurl = process.env.BaseUrl;
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js:16
- [nitpick] The comment 'Replace with actual PDF icon URL' is vague. It should be more specific or removed if not necessary.
return `${ baseurl }/icons/PDFIcons.png`; // Replace with actual PDF icon URL
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js:30
- The method 'handleTeamsMessagingExtensionSubmitAction' does not have test coverage for the adaptive card creation.
async handleTeamsMessagingExtensionSubmitAction(context, action) {
samples/msgext-thirdparty-storage/nodejs/README.md:11
- The term 'contentType' should be 'content type'.
contentType: samples
samples/msgext-thirdparty-storage/nodejs/README.md:12
- The term 'createdDate' should be 'created date' and the date format should be 'YYYY-MM-DD'.
createdDate: "26-12-2024 17:00:25"
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 33 out of 48 changed files in this pull request and generated 4 comments.
Files not reviewed (15)
- samples/msgext-thirdparty-storage/nodejs/.env: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.gitignore: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/extensions.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/launch.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/settings.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/.vscode/tasks.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/appManifest/manifest.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/assets/sample.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/env/.env.local: Language not supported
- samples/msgext-thirdparty-storage/nodejs/infra/azure.bicep: Language not supported
- samples/msgext-thirdparty-storage/nodejs/infra/azure.parameters.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/package.json: Language not supported
- samples/msgext-thirdparty-storage/nodejs/public/styles.css: Language not supported
- .github/workflows/build-complete-samples.yml: Evaluated as low risk
- README.md: Evaluated as low risk
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js
Outdated
Show resolved
Hide resolved
samples/msgext-thirdparty-storage/nodejs/bots/teamsMessagingExtensionsActionBot.js
Show resolved
Hide resolved
mahimaMSFT
approved these changes
Jan 6, 2025
mahimaMSFT
approved these changes
Jan 6, 2025
Wajeed-msft
approved these changes
Jan 6, 2025
Harikrishnan-MSFT
requested review from
TrevorJoelHarris
and removed request for
TrevorJoelHarris
Pawank-MSFT
approved these changes
Jan 6, 2025
| @@ -0,0 +1,72 @@ | |||
| { | |||
| "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.9/MicrosoftTeams.schema.json", | |||
There was a problem hiding this comment.
Please update latest manifest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.