Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Hello world Python Sample Added #1477

Merged

Conversation

Mohammed-MSFT
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct.

samples/app-hello-world/python/Images/AppHelloWorldGif.gif Outdated Show resolved Hide resolved
@Pawank-MSFT Pawank-MSFT requested a review from Copilot January 3, 2025 10:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 24 out of 39 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • samples/app-hello-world/python/.gitignore: Language not supported
  • samples/app-hello-world/python/.vscode/extensions.json: Language not supported
  • samples/app-hello-world/python/.vscode/launch.json: Language not supported
  • samples/app-hello-world/python/.vscode/settings.json: Language not supported
  • samples/app-hello-world/python/.vscode/tasks.json: Language not supported
  • samples/app-hello-world/python/appManifest/manifest.json: Language not supported
  • samples/app-hello-world/python/assets/sample.json: Language not supported
  • samples/app-hello-world/python/env/.env.local: Language not supported
  • samples/app-hello-world/python/infra/azure.bicep: Language not supported
  • samples/app-hello-world/python/infra/azure.parameters.json: Language not supported
  • samples/app-hello-world/python/requirements.txt: Language not supported
  • samples/app-hello-world/python/src/views/configure.html: Language not supported
  • samples/app-hello-world/python/src/views/first.html: Language not supported
  • samples/app-hello-world/python/src/views/hello.html: Language not supported
  • samples/app-hello-world/python/src/views/second.html: Language not supported
Comments suppressed due to low confidence (1)

samples/app-hello-world/python/app.py:38

  • [nitpick] The error message could be more descriptive. Consider changing it to: 'The bot encountered an unexpected error. Please try again later.'
await context.send_activity("The bot encountered an error or bug.")

samples/app-hello-world/python/app.py Outdated Show resolved Hide resolved
@Jegadeesh-MSFT
Copy link
Contributor

Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good Approved!!!

Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, approving!

@Harikrishnan-MSFT Harikrishnan-MSFT merged commit 6fc4a07 into main Jan 6, 2025
271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants