msgext-search-auth-config python code fix and image update #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pawank-MSFT
reviewed
Jan 2, 2025
Pawank-MSFT
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- samples/msgext-search-auth-config/python/appManifest/manifest.json: Language not supported
- samples/msgext-search-auth-config/python/requirements.txt: Language not supported
Comments suppressed due to low confidence (1)
samples/msgext-search-auth-config/python/bots/teams_messaging_extensions_search_auth_config_bot.py:97
- The Adaptive Card version specified is 1.5, which may not be supported by all clients. Consider using version 1.2 for broader compatibility.
"type": "AdaptiveCard",
...s/msgext-search-auth-config/python/bots/teams_messaging_extensions_search_auth_config_bot.py
Show resolved
Hide resolved
...s/msgext-search-auth-config/python/bots/teams_messaging_extensions_search_auth_config_bot.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- samples/msgext-search-auth-config/python/appManifest/manifest.json: Language not supported
- samples/msgext-search-auth-config/python/requirements.txt: Language not supported
Comments suppressed due to low confidence (1)
samples/msgext-search-auth-config/python/bots/teams_messaging_extensions_search_auth_config_bot.py:94
- [nitpick] The method name 'handle_teams_app_based_anonymous_link_query' is too long. Consider renaming it to something more concise, such as 'handle_anonymous_link_query'.
async def handle_teams_app_based_anonymous_link_query(self, turn_context: TurnContext, value):
...s/msgext-search-auth-config/python/bots/teams_messaging_extensions_search_auth_config_bot.py
Show resolved
Hide resolved
Harikrishnan-MSFT
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.