Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement toolkit Python Auth Samples #1466

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

Harikrishnan-MSFT
Copy link
Contributor

No description provided.

@Harikrishnan-MSFT Harikrishnan-MSFT changed the title Implement toolkit python auth samples Implement toolkit Python Auth Samples Nov 29, 2024
Copy link
Collaborator

@frankqianms frankqianms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix small comments

@@ -2,7 +2,8 @@
"$schema": "https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json",
"manifestVersion": "1.19",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons not needed for appManifest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need FYI
image

@@ -2,7 +2,8 @@
"$schema": "https://developer.microsoft.com/json-schemas/teams/v1.19/MicrosoftTeams.schema.json",
"manifestVersion": "1.19",
"version": "1.0.0",
"id": "<<YOUR-MICROSOFT-APP-ID>>",
"id": "${{TEAMS_APP_ID}}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons not needed for appManifest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need FYI
image

Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, approving!

@Harikrishnan-MSFT
Copy link
Contributor Author

@Harikrishnan-MSFT Harikrishnan-MSFT merged commit f6181bc into main Dec 5, 2024
271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants