Merge pull request #1003 from OfficeDev/v-mfurquan/fixes-for-app-sso

App SSO Fixes
OfficeDev · Oct 23, 2023 · 288b6da · 288b6da
2 parents 9ed3f61 + 171f9c6
commit 288b6da
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 12 deletions.
diff --git a/samples/app-sso/csharp/App SSO Sample/AdapterWithErrorHandler.cs b/samples/app-sso/csharp/App SSO Sample/AdapterWithErrorHandler.cs
@@ -4,6 +4,7 @@
 using System;
 using Microsoft.Bot.Builder;
 using Microsoft.Bot.Builder.Integration.AspNet.Core;
+using Microsoft.Bot.Builder.Teams;
 using Microsoft.Bot.Builder.TraceExtensions;
 using Microsoft.Bot.Connector.Authentication;
 using Microsoft.Extensions.Configuration;
@@ -13,9 +14,11 @@ namespace Microsoft.BotBuilderSamples
 {
     public class AdapterWithErrorHandler : CloudAdapter
     {
-        public AdapterWithErrorHandler(BotFrameworkAuthentication auth, ILogger<IBotFrameworkHttpAdapter> logger, ConversationState conversationState = null)
-            : base(auth, logger)
+        public AdapterWithErrorHandler(IConfiguration configuration, IStorage storage, BotFrameworkAuthentication auth, ILogger<IBotFrameworkHttpAdapter> logger, ConversationState conversationState = null)
+            : base(auth,logger)
         {
+            base.Use(new TeamsSSOTokenExchangeMiddleware(storage, configuration["ConnectionName"]));
+
             OnTurnError = async (turnContext, exception) =>
             {
                 // Log any leaked exception from the application.

diff --git a/samples/app-sso/csharp/App SSO Sample/Bots/DialogBot.cs b/samples/app-sso/csharp/App SSO Sample/Bots/DialogBot.cs
@@ -308,7 +308,7 @@ private async Task<TokenResponse> GetTokenResponse(ITurnContext<IInvokeActivity>
             }
 
             var userTokenClient = turnContext.TurnState.Get<UserTokenClient>();
-            var tokenResponse = await userTokenClient.GetUserTokenAsync(turnContext.Activity.From.Id, _connectionName, turnContext.Activity.ChannelId, magicCode, cancellationToken);
+            var tokenResponse = await userTokenClient.GetUserTokenAsync(turnContext.Activity.From.Id, _connectionName, turnContext.Activity.ChannelId, magicCode, cancellationToken).ConfigureAwait(false);
 
             return tokenResponse;
         }

diff --git a/samples/app-sso/csharp/App SSO Sample/Dialogs/LogoutDialog.cs b/samples/app-sso/csharp/App SSO Sample/Dialogs/LogoutDialog.cs
@@ -46,17 +46,22 @@ public LogoutDialog(string id, string connectionName)
         {
             if (innerDc.Context.Activity.Type == ActivityTypes.Message)
             {
-                var text = innerDc.Context.Activity.Text.ToLowerInvariant();
 
-                // Allow logout anywhere in the command
-                if (text.IndexOf("logout") >= 0)
+                var text = innerDc.Context.Activity.Text;
+                if (text != null)
                 {
-                    // The bot adapter encapsulates the authentication processes.
-                    var botAdapter = innerDc.Context.Adapter;
-                    var userTokenClient = innerDc.Context.TurnState.Get<UserTokenClient>();
-                    await userTokenClient.SignOutUserAsync(innerDc.Context.Activity.From.Id, ConnectionName, innerDc.Context.Activity.ChannelId, cancellationToken);
-                    await innerDc.Context.SendActivityAsync(MessageFactory.Text("You have been signed out."), cancellationToken);
-                    return await innerDc.CancelAllDialogsAsync(cancellationToken);
+                    text = innerDc.Context.Activity.Text.ToLowerInvariant();
+
+                    // Allow logout anywhere in the command
+                    if (text.IndexOf("logout") >= 0)
+                    {
+                        // The bot adapter encapsulates the authentication processes.
+                        var botAdapter = innerDc.Context.Adapter;
+                        var userTokenClient = innerDc.Context.TurnState.Get<UserTokenClient>();
+                        await userTokenClient.SignOutUserAsync(innerDc.Context.Activity.From.Id, ConnectionName, innerDc.Context.Activity.ChannelId, cancellationToken);
+                        await innerDc.Context.SendActivityAsync(MessageFactory.Text("You have been signed out."), cancellationToken);
+                        return await innerDc.CancelAllDialogsAsync(cancellationToken);
+                    }
                 }
             }