Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: port mapping for Django in the devcontainer #11

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Feat: port mapping for Django in the devcontainer #11

merged 1 commit into from
Feb 13, 2025

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Feb 12, 2025 •
edited
Loading

Follow up to #8 (review)

Reviewing

  1. Checkout this branch
  2. Rebuild and reopen the devcontainer
  3. F5 to launch the test app
  4. Confirm a port mapping for the internal port 8000 to a dynamically assigned localhost port, the site is available

@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman self-assigned this Feb 12, 2025
angela-tran
angela-tran approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

image

lalver1
lalver1 approved these changes Feb 12, 2025
View reviewed changes
Copy link

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on a Mac too 🙂 (with Auto Forward Ports disabled in the VS Code settings, just in case)

image

@thekaveman thekaveman merged commit 7a700c2 into main Feb 13, 2025
3 checks passed
@thekaveman thekaveman deleted the feat/port-mapping branch February 13, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalver1 lalver1 lalver1 approved these changes

@angela-tran angela-tran angela-tran approved these changes

@machikoyasuda machikoyasuda Awaiting requested review from machikoyasuda

Assignees

@thekaveman thekaveman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thekaveman @lalver1 @angela-tran