Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] : redis cluster status after scale up #682

Closed
wants to merge 13 commits into from
Closed

[Fix] : redis cluster status after scale up #682

wants to merge 13 commits into from

Conversation

drivebyer
Copy link
Collaborator

  1. Fix redis cluste ready node no changed afte scale up
  2. Add e2e test for scale up

@drivebyer drivebyer added the bug Something isn't working label Oct 28, 2023
@drivebyer drivebyer self-assigned this Oct 28, 2023
@drivebyer drivebyer enabled auto-merge (squash) October 28, 2023 04:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023 •
edited
Loading

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
k8sutils/statefulset.go 28.13% <ø> (+0.05%) ⬆️
k8sutils/poddisruption.go 0.00% <0.00%> (ø)
controllers/rediscluster_controller.go 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@shubham-cmyk
Copy link
Member

@drivebyer

Can we also make sure here that the scale-down is working properly here ?

We could have another 02-scale-down.yaml

@drivebyer
Copy link
Collaborator Author

drivebyer commented Oct 28, 2023 •
edited
Loading

@drivebyer

Can we also make sure here that the scale-down is working properly here ?

We could have another 02-scale-down.yaml

I would add it.

drivebyer and others added 7 commits October 29, 2023 19:30
@drivebyer @shubham-cmyk
temp
ec60ef0 
Signed-off-by: drivebyer <[email protected]>
@drivebyer @shubham-cmyk
remove redundant if clause
4655e92 
Signed-off-by: drivebyer <[email protected]>
@drivebyer @shubham-cmyk
fix cluster status
baec8a3 
Signed-off-by: drivebyer <[email protected]>
@drivebyer @shubham-cmyk
add case path
113fe78 
Signed-off-by: drivebyer <[email protected]>
@drivebyer @shubham-cmyk
change follower to 9
5be444a 
Signed-off-by: drivebyer <[email protected]>
@drivebyer @shubham-cmyk
add scale down step
d073f9d 
Signed-off-by: drivebyer <[email protected]>
@shubham-cmyk
Add status
11f7ba0 
Signed-off-by: Shubham Gupta <[email protected]>
shubham-cmyk and others added 6 commits October 29, 2023 20:03
@shubham-cmyk
fix : err
d9461cc 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
remove timestamp
14f23f3 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
add more status
887d1ff 
Signed-off-by: Shubham Gupta <[email protected]>
@drivebyer
change level
4dcdda3 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
change print log level
c520ab2 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
fix log
dbbe722 
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer closed this Dec 7, 2023
auto-merge was automatically disabled December 7, 2023 07:02

Pull request was closed

@drivebyer drivebyer deleted the cluster-scale branch December 7, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk Awaiting requested review from shubham-cmyk shubham-cmyk is a code owner

Assignees

@drivebyer drivebyer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drivebyer @codecov-commenter @shubham-cmyk