Fix container cleanup #58
Merged
+51
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A flake configured to be attached can also be re-started using the same container storage. However, the container was always removed when the command exited. This commit fixes it to avoid removing the container of attach type flakes. In addition a flake option %remove was added to allow removing the container created for resume and attach type flakes
Use get_run_cmdline method everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix container cleanup
A flake configured to be attached can also be re-started using the same container storage. However, the container was always removed when the command exited. This commit fixes it to avoid removing the container of attach type flakes. In addition a flake option %remove was added to allow removing the container created for resume and attach type flakes
Fix building runtime arguments
Use get_run_cmdline method everywhere