Make sure system mount point exists for sci #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reboot, terminal allocation and pivot of a firecracker machine requires access to sysrq, pts devices and more. sci mounts all kernel filesystems but this requires the mountpoints /proc, /sys /dev, /dev/pts to be available. Some prebuild firecracker images comes without these mountpoints (non FHS compliant btw). With this commit we make sure that at registration time the image has this mountpoint such that the sci issued system mounts can succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot, terminal allocation and pivot of a firecracker machine requires access to sysrq, pts devices and more. sci mounts all kernel filesystems but this requires the mountpoints /proc, /sys /dev, /dev/pts to be available. Some prebuild firecracker images comes without these mountpoints (non FHS compliant btw). With this commit we make sure that at registration time the image has this mountpoint such that the sci issued system mounts can succeed.