Get collection exercises by survey ids #1032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.4...3.1.5) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…o get-ces-by-survey-ids
|
/deploy wilkia |
|
Deploying to dev cluster with following parameters:
|
anwilkie
approved these changes
Jan 29, 2025
LJBabbage
requested changes
Feb 4, 2025
There was a problem hiding this comment.
So I don't believe this will work if there are no enrolments and will throw an exception. I also am not sure why this is still stored in redis, hasn't that been made redundant? I am also wonder what exercise /surveys is also being used for (if any) as it has been extended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Swaps out the get collection exercises by survey id with get collection exercises by survey ids to reduce the number of calls to collection exercise from one per survey the respondent has, to just one for all the surveys the respondent has
How to test?
Jira
RAS-1401