Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we use the new video embed block on the statistical article and methodology pages #93

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

helenb
Copy link
Contributor

@helenb helenb commented Jan 29, 2025

What is the context of this PR?

https://jira.ons.gov.uk/browse/CMS-326

When the new video embed block was created, we didn't add it to the SectionContentBlock, so it was missed from the statistical article and methodology pages

How to review

Follow-up Actions

Update the ticket with instructions for testing.

@helenb helenb requested a review from a team as a code owner January 29, 2025 14:38
@helenb helenb marked this pull request as draft January 29, 2025 14:40
@helenb helenb marked this pull request as ready for review January 29, 2025 14:42
Copy link
Contributor

@nehakerung nehakerung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helenb helenb merged commit a249742 into main Jan 30, 2025
9 checks passed
@helenb helenb deleted the fix/add-ons-video-embed-block-to-section-story-block branch January 30, 2025 10:34
Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants