Fix: Only ignore the root/automatically-compiled 'static' dirs #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
changed the title
zerolab
reviewed
Jan 21, 2025
helenb
reviewed
Jan 21, 2025
ababic
changed the title
helenb
approved these changes
Jan 21, 2025
added 2 commits
January 21, 2025 14:29
… folders... not app-specific ones
ababic
force-pushed
the
fix/allow-app-specific-static-files-in-gitignore
branch
from
b1f0308 to
ff0ca48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The .gitignore file is currently a little bit too overbearing, and doesn't account for when apps that have their own staticfiles. This caused pain most recently on #80, where it worked fine locally, but not on anybody Helen's machine. But, as the project grows, it's likely to trip developers up unnecessarily on other threads of work too.
How to review
Add a
staticfolder to an existing app and plonk a random file in it.git statusshould reflect the addition of that file.