Main Menu #41
Main Menu #41
Conversation
…ed, section restricted to 3, URL label added, icon for navigation settings added and restricting it to so only 1 main menu can be created
There was a problem hiding this comment.
Thanks @sanjeevz3009 I have tested locally and it all functions well. A couple of small comments on the validation and example help text.
@helenb Will push my latest code up as I haven't done that. It should be way better =) Might resolve some of the issues raised by you. Thanks Helen, will sort out any issues not addressed already locally and then push it up. |
…ate one main menu instance in the wagtail admin. Migration file added.
…ks.base to be reusable across the project. LinkBlock from core.blocks.base is being used instead of the abstract class originally defined in models.py.
…enuViewSet added to restrict creating more than one main menu instance
|
I don't think the menu is using the styling quite as expected - compare my test with the menu settings (first screenshot) with what is in the prototype (second screenshot). I'm happy to pick that up as a follow-up task. 
|
|
Thanks for testing this. I fixed the link issues. As previously for highlights when a user selects a Wagtail page it didn't turn it into a link. Now it does. Same for the topic page. Also fixed some other edge cases I missed out on previously, so now all should be good on that side. Let me know if there are any further issues. Now adding main menu content and it being usable on the website menu should be all good.
So now we are just left with front-end alignment issues.
Would be amazing if you could follow that up on a task. Happy to demo the front-end styling/ alignment issues to you. Thanks =) |
Noting for completeness that these issues are addressed in #63 |
@helenb Thank you Helen for this. We did have a good discussion about this. Yes, we will be reiterating this in the future especially when we get to Wagtail workflows etc. Additionally, as we discussed there are more questions that need to be answered and decisions that need to be made around the main menu features from having multiple main menus or having a single one, if we do maybe make it so we don't have to choose that in the navigation settings like you mentioned and also this is something @AdamHawtin pointed out and something I had in my mind. In most of these cases, @MebinAbraham and I have discussed these caveats. I guess for now this is good as a first iteration, as we already scope creeped quite a bit in some areas. I have made some notes of the feedback from you and @AdamHawtin. I will have some discussions with @MebinAbraham in capturing some of this somewhere or creating cards etc if needed soon. Thanks! |
Thanks, Helen, tested this out and it works great, when I remember to do npm build on the branch I have your branch pulled into =) |
There was a problem hiding this comment.
Agree with the points @helenb raised, I found the workflow odd around being locked down to one main menu snippet, but then the settings menu still behaving as though there was a choice, but as a starting point to iterate on this, looks good, apart from small styling niggles noted the menu and editor options all work and look good.
It seems like the two rough paths we could go down to improve this are either:
- Allow multiple different main menu snippets to be created, and allow users to then choose which is currently active. This would then allow users to either directly edit the active menu for small changes and/or author a new, separate, main menu snippets and switch over when they want them to become the active, published menu.
- Stick to only allowing one main menu snippet which must be edited directly to make changes, but then also do the work to make this one main menu always active by default since it is the only choice.
We should probably also look at either removing the main menu drop down when no menu has been created, or populating some sensible defaults?
|
On having the navigation settings + menus as snippets:
|
There was a problem hiding this comment.
Approved in the basis #85 and other future tickets will fix my outstanding comments.
* Front-end hacked together to complete the back-end * Navigation app added, models created for navigation settings * Navigation bar on the front-end test * Front-end code reverted due to the front-end main menu being done separately * New line * Code formatted * Type hinted and code formatted * Code refactored, abstract link class created, validation messages added, section restricted to 3, URL label added, icon for navigation settings added and restricting it to so only 1 main menu can be created * Migration file * Main menu modelling complete, restricting user to be able to only create one main menu instance in the wagtail admin. Migration file added. * LinkBlock extracted out of core.blocks.related and moved to core.blocks.base to be reusable across the project. LinkBlock from core.blocks.base is being used instead of the abstract class originally defined in models.py. * Code formatted, zombie code removed, unused imports removed and MainMenuViewSet added to restrict creating more than one main menu instance * Front-end integrated * Type hints added * Nav template issues fixed * gettext_lazy added * Preview added * Use the title provided by the user over the default title from the page * help text update * Type hints added * Migration file regenerated * Tests added * TODO removed and translatable added * Description help text updated * Tests setup * Example StreamField value setting in test_highlights_streamfield_limit * Debug * Errors being raised when adding more than 3 highlights * Committing working factories to save * Clean method for ColumnBlock added and tests updated * Updated tests * test_section_streamfield_limit test working * Added more tests, factories updated * Removed tests * Max num code removed * Code formatted * Utilising pageurl to point to get internal wagtail pages * Code refactored * Reverting format for md files * Reverting md files formatting * Lint errors corrected * Unused import removed and base template updated * Base template update * Type checking added back in * Template code updated to make sure to only display live wagtail pages * Main menu live preview fixed * MegaLinter errors fixed * Using a preview template for live previews * Mark NavigationSettings as allowed for write in ExternalEnvRouter * Use our own BaseSiteSetting which works with the ExternalEnvRouter * RevisionMixin implementation and mypy fix * Blocks refactor * Code linted * Tests for main menu viewset added * Type ignore added * Duplicate page and external URL validation for sections and topic links within columns complete. * Duplicate page and URL for columns complete. * test_forms in place * Update test_clean_highlights_no_duplicate test * Tests complete for forms.py * test_forms.py code clean up * Example usage zombie code removed * Code formatted and refactored * Code refactored, type hinted, tests refactored. * gettext translation added * LinkBlock Factory moved * De-nest the blocks tests folder
* Navigation templates tags added * base template updated to use navigation template tags functionality, navigation_template_tags added and navigation_tags refactored. * Main Menu (#41) * _extract_highlight_item and _extract_url_item combined into one reusable function * Type hinting fixed * Using get_dummy_quest from wagtail for mocking requests * Accidental files added, now removed * Class CommonItem renamed to NavigationItem * save method being called in test_navigation_tags
What is the context of this PR?
Add a navigation app in Wagtail to manage the main menu, allowing for structured, customisable navigation.
How to review
Loom walkthrough of the main menu: Main Menu Features Loom Walkthrough
Credit: @zerolab for the help and guidance.
Follow-up Actions
Fix column alignment issues (can be seen during the loom video): #63