Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR tweaks] Show the rich text toolbar and the minimap by default #106

Merged
merged 10 commits into from
Feb 25, 2025

Conversation

kacperpONS
Copy link
Contributor

@kacperpONS kacperpONS commented Feb 20, 2025

What is the context of this PR?

Following User Research we've identified the need to change the default behaviour of the Wagtail editor - we want the rich text toolbar to be pinned at the top of the input field and the editor minimap to be shown.

Functional tests have been added to check for the default behaviour and storing user preferences.

Walkthrough: https://www.loom.com/share/52fb408fa2d24b3290a2977b3ff919f2

How to review

  1. Run Wagtail and open it in an incognito window (alternatively clear local storage in the dev browser console).
  2. Go to page editor and check that:
    • the rich text toolbar is pinned at the top of the input field.
    • the page editor minimap is shown on the right
  3. Then unpin the toolbar and hide the editor then refresh the page to check that the preference is saved.

Also, run the functional tests.

Link to Jira

https://jira.ons.gov.uk/browse/CMS-353

@kacperpONS kacperpONS marked this pull request as ready for review February 20, 2025 19:22
@kacperpONS kacperpONS requested a review from a team as a code owner February 20, 2025 19:22
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a screencast for this please.

Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor (non-blocking) nitpick.

@MebinAbraham MebinAbraham changed the title [UR tweaks] Show the rich text toolbar and the minimap by default CMS-353 [UR tweaks] Show the rich text toolbar and the minimap by default Feb 25, 2025
@kacperpONS kacperpONS merged commit 39cdf96 into main Feb 25, 2025
9 checks passed
@kacperpONS kacperpONS deleted the show-richtext-toolbar-and-minimap-by-default-CMS-353 branch February 25, 2025 10:20
Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants