Fix broken dev Redis default config #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperpONS
approved these changes
Feb 12, 2025
kacperpONS
added a commit
that referenced
this pull request
Feb 12, 2025
zerolab
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Reviewed! Everything works as expected! Thanks @AdamHawtin !
kacperpONS
added a commit
that referenced
this pull request
Feb 24, 2025
* Add fix from PR #101 * Added the test * Ignore pylint errors * Make them pass * Fix an issue with tests failing in headless and passing in headed mode * Rewording to match steps pulled from main * Formatting + rewording * Revert a change to make tests pass * A bunch of improvements * Remove no longer needed file for theme page set up * Remove duplicated step definition * Add missing assertion * Topic page test fix * Added missing checks + where I got with testing preview (failing so commented out) * Formatting - all green locally * Test * Attempt to fix headless failures * Bump the wait time a bit * Refactor the fix above into it's own step * Uncommented the preview test * Added a test for the draft functionality of the page * Refactoring * Renamed a test function * Experiment - removed the delay in preview test * ^ the same for the mandatory fields scenario 🤔 * Add back the delay for mandatory fields scenario + make step wording more precise * Experiment - move the delay to the 'then' step of the mandatory fields scenario * ^ revert the above * Experiment - replace delay with wait_for_load_state * ^ the same but after clicking the button * Revert to using delay * Test improvements --------- Co-authored-by: Dan Braghiș <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
#76 Introduced an issue with the developer config where I incorrectly assumed
REDIS_URLset indev.pywould properly populate the Redis configuration, instead it would incorrectly fall back on broken database caching which we do not want.How to review
Check out the this branch
Run
make compose-dev-upRename or remove any local
.envorlocal.pyconfig filesTry starting the wagtail app from the command line or IDE
The app should successfully start, not hit an error around database cache tables.